[cristim]

What

PUT /api/plans/{id} rebuilds the ramp schedule from the request. When the requested shape (type, percent per step, interval, step count) differed from the stored one, the plan restarted at step 0 and forgot the percentage already bought. A PUT that omitted ramp_schedule did the same, because it defaults to immediate.

Now updatePlan returns 409 when the stored plan has CurrentStep > 0 and the requested shape differs. The message says to resend the current ramp_schedule to keep it, or create a new plan. Same-shape edits (rename, coverage, ...) and shape changes at step 0 behave as before. The 409 is documented on PUT /api/plans/{id} in openapi.yaml.

Owner decision (fleet lead): reject rather than carry progress. Carrying the completed percentage into the new schedule (ceil(done/newPct) steps complete) remains an option if the owner wants it later; it needs an "effective target" definition that does not exist yet.

mergeUpdatedPlan is extracted from updatePlan only to stay under the gocyclo limit.

Scope of #386

Refs #386, which listed four follow-ups. Only item 1 was still open:

• 2 (updatePlan race): fixed by 19cfb35 (conditional write, 409 on conflict)
• 3 (run-now error mapping, ExecutedAt stamp, real status): fixed by ad84d14 and 8cb5c78
• 4 (revoke-any account scope): fixed by 8761425

The issue stays open until this merges.

Tests

TestUpdatePlan_RampShapeChange drives PUT through the router: step 3 weekly-25% to monthly-10% (409, nothing stored), omitted ramp_schedule (409), different custom percent (409), same shape keeps step 3 (200), shape change at step 0 (200, new schedule saved). With the handler change reverted the step-3 rows fail (200 instead of 409). go test -short ./internal/api passes. Fixture-based (mock store), not a live database.

Removed TestHandler_updatePlan_ChangingRampScheduleStartsAtStepZero, which asserted the old restart behavior.

Local independent review (two passes): no actionable findings after the wording and test-coverage fixes.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 4 billable files and costs up to $1.00.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 10 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 82 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: 63c88404-45d7-46da-90bf-812a614f0daa

---

📥 Commits

Reviewing files that changed from the base of the PR and between 30d6c84 and 613e907.

---

📒 Files selected for processing (4)

• internal/api/handler_plans.go
• internal/api/handler_plans_ramp_shape_test.go
• internal/api/handler_plans_test.go
• internal/api/openapi.yaml

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}