Repository navigation
fix(scripts): make setup-git-secrets idempotent - #641
Merged
Merged
Conversation
git secrets --add exits 1 for an already-registered pattern, so under set -e a second make setup-git-secrets aborted at the first custom pattern and left the GCP, Azure, database and PEM detectors unapplied. Register patterns through add_pattern, which skips ones already present and still fails on a real error. Add a second-run check to the allowlist self-test.
cristim
added
priority/p2
Contributor
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 1 minute for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 68 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #296
Adds
add_patterntoscripts/setup-git-secrets.sh: it skips a pattern already insecrets.patternsand otherwise runsgit secrets --add, so a real error still stops the script (unlike|| true). The three self-matching.gitallowedentries are re-anchored onadd_pattern '.scripts/test-git-secrets-allowlist.shnow runs setup a second time and checks it succeeds with an unchanged pattern count.Checks: reproduced on main (run 1 rc=0, run 2 rc=1, GCP/Azure/DB/PEM patterns skipped). With the fix both runs rc=0 and 15 patterns each time.
scripts/test-git-secrets-allowlist.shpasses (36 PASS) and fails on main's setup script. shellcheck reports only the pre-existing unused-color-variable warnings.Note: #295 edits the same section; its PR is stacked on this branch.