Repository navigation
fix(ci): read GCP_PROJECT_ID from vars in rollback.yml - #637
Merged
Merged
Conversation
deploy-gcp.yml and cleanup-staging.yml read it from repository variables. rollback.yml read secrets.GCP_PROJECT_ID, so on a repo configured per the other workflows the validate job refused to run and a GCP rollback was blocked during an incident.
cristim
added
priority/p2
Contributor
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 59 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 68 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Comment |
The workflows README listed it under secrets and told operators to run gh secret set, but every GCP workflow reads vars.GCP_PROJECT_ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #300
Both
rollback.ymlreferences (validate job and the Terraform rollback job) now readvars.GCP_PROJECT_ID, matchingdeploy-gcp.ymlandcleanup-staging.yml. The error message and header comment now say variable.Checks: actionlint clean. Workflows cannot be run locally; CI is the check.
Docs: .github/workflows/README.md now lists GCP_PROJECT_ID under Required Variables and uses gh variable set. Other repo mentions (cmd/rekey/README.md:79, known_issues/resolved/25_*.md) refer to process environment variables and are correct.