Skip to content

fix(ci): resolve AWS_REGION at job level in the AWS deploy workflows #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Oct 6, 2026
Merged

fix(ci): resolve AWS_REGION at job level in the AWS deploy workflows #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/deploy-aws-fargate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ on:
required: true

env:
AWS_REGION: ${{ vars.AWS_REGION || 'us-east-1' }}
TF_VERSION: '1.10.0'
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

Expand Down Expand Up @@ -142,6 +141,11 @@ jobs:
outputs:
alb_url: ${{ steps.outputs.outputs.alb_url }}
service_name: ${{ steps.outputs.outputs.service_name }}
# Set at job level, not workflow level: workflow-level `env:` is resolved
# before this job's `environment:` is in scope, so an environment-scoped
# AWS_REGION variable would be invisible there. Matches cleanup-staging.yml.
env:
AWS_REGION: ${{ vars.AWS_REGION || 'us-east-1' }}
environment:
name: aws-fargate-${{ needs.prepare.outputs.target_environment }}
url: ${{ steps.outputs.outputs.alb_url }}
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/deploy-aws-lambda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ on:
required: true

env:
AWS_REGION: ${{ vars.AWS_REGION || 'us-east-1' }}
TF_VERSION: '1.10.0'
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

Expand Down Expand Up @@ -232,6 +231,11 @@ jobs:
# all share one value — producing wrong email links in customer
# mailboxes. Per CR review on PR #368.
environment: ${{ needs.prepare.outputs.target_environment }}
# Set at job level, not workflow level: workflow-level `env:` is resolved
# before this job's `environment:` is in scope, so an environment-scoped
# AWS_REGION variable would be invisible there. Matches cleanup-staging.yml.
env:
AWS_REGION: ${{ vars.AWS_REGION || 'us-east-1' }}
outputs:
function_url: ${{ steps.outputs.outputs.function_url }}
function_name: ${{ steps.outputs.outputs.function_name }}
Expand Down Expand Up @@ -378,6 +382,11 @@ jobs:
# Bind to the same named environment as build-and-deploy so that
# vars.AWS_ROLE_TO_ASSUME resolves to the per-environment scoped value.
environment: ${{ needs.prepare.outputs.target_environment }}
# Set at job level, not workflow level: workflow-level `env:` is resolved
# before this job's `environment:` is in scope, so an environment-scoped
# AWS_REGION variable would be invisible there. Matches cleanup-staging.yml.
env:
AWS_REGION: ${{ vars.AWS_REGION || 'us-east-1' }}

steps:
- name: Configure AWS credentials
Expand Down
Loading