[cristim]

Closes #522

State on main (3413591): the propagation half is fixed by #538 (changed coverage wins over stale service rows, settings.ts saveGlobalSettings, defaultCoverageChanged), and save-time rejection of an empty global coverage is in place (settings.ts:3495-3496, tested at settings.test.ts 'an empty global coverage field is rejected instead of saving 0'). The plans.ts:1345 reference in the issue is stale (that line is now deletePlanAction, no coverage code).

Still present: the issue's acceptance asks for an inline error. wireInlineRangeValidation (settings.ts check()) treats an empty value as valid and hides the error, so the field shows no indication until Save.

Fix: new required option on wireInlineRangeValidation; an empty value is invalid when set. Enabled only for setting-default-coverage; other fields keep the empty-clears-error behavior. Message is the existing range message, same as the save toast wording.

Tests (settings.test.ts, inline range validation block): empty coverage on input shows aria-invalid and the visible error; empty notification-days stays clean. On main the first fails because check() returns early on raw === '' (read step by step; jest cannot run offline here, CI is the authority).

Decision: required is opt-in rather than changing the default, to leave other fields unchanged.

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 2 billable files and costs up to $0.50.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 6 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 68 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: 37c149fd-0d7b-4359-82af-06f08af0281d

📥 Commits

Reviewing files that changed from the base of the PR and between 3413591 and 5ec19a2.

📒 Files selected for processing (2)

• frontend/src/__tests__/settings.test.ts
• frontend/src/settings.ts

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}