Repository navigation
fix(auth): report a deactivated user's reset token as used - #592
Merged
Merged
Conversation
ResetTokenStatus returned valid for an unexpired token belonging to an admin-deactivated user, so the frontend rendered a form that ConfirmPasswordReset always refuses with 403. Report used instead, matching unknown and consumed tokens so the endpoint does not reveal the deactivation. Closes #421
cristim
added
triaged
Contributor
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 49 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Comment |
…onses Pin expiry-before-deactivation ordering in ResetTokenStatus and compare status, headers and body between unknown and deactivated tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #421
ResetTokenStatus now returns state used (flow reset) for an unexpired token of an admin-deactivated user, so the frontend shows the terminal view instead of a form that ConfirmPasswordReset refuses with 403. Expired tokens still report expired; no new existence oracle (deactivated is indistinguishable from unknown/consumed).
Tests: service unit test updated; new HandleRequest tests in internal/server (real auth.Service, mock store) for the status endpoint (fails before, passes after) and the confirm path (403).