Repository navigation
fix(sec): percent-encode or quote the database password in remaining DSN builders - #588
Merged
Merged
Conversation
…DSN builders Encode the password with jq -sRr @uri in the CI migrate step and the DEPLOYMENT.md migrate commands, build the testutil connection string with url.UserPassword, and single-quote keyword DSN passwords that contain whitespace, quotes or backslashes. Round-trip tests parse the result back with pgx.
Contributor
|
Warning Review limit reached
This review includes 6 billable files and costs up to $1.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 43 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (6)
Comment |
…ords Make the second DEPLOYMENT.md migrate block extract .password like the first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #557
Follows #555 and #556. Applies the same encoding to the remaining builders:
jq -sRr @uri.Tests parse the DSN back with pgconn.ParseConfig using a password with @ : / % # ? space and both quote kinds; both fail on main and pass here.
Not changed: scripts/entrypoint.sh keeps its awk encoder (the container may not ship jq); unifying it is left open. Refs rather than Closes for that reason.