[cristim]

What

savePurchaseHistory stamped a literal "convertible" into purchase_history.offering_class for every AWS EC2 purchase. The EC2 client in the pinned cloud-commitments-go/providers/aws (services/ec2/client.go resolveOfferingClassType) buys the class from global_config.offering_class, which can be "standard". The stamp also matched only the legacy "ec2" slug, so canonical "compute" recs got no class at all.

The marketplace-sell guard (internal/api/handler_marketplace.go) reads this column instead of asking AWS, so every Standard RI bought by CUDly was recorded as unsellable.

How

• processPurchaseRecommendations resolves the configured class once into an ec2types.OfferingClassType (resolveEC2OfferingClass, same mapping as the pinned client: "" and "convertible" give Convertible, "standard" gives Standard).
• An unknown value returns errUnknownOfferingClass before any provider client is built. Previously the error came per EC2 rec from the provider. Config writes already reject unknown values (config.validateOfferingClass), so this only fires on a tampered or corrupted row.
• savePurchaseHistory stamps the resolved class for AWS recs whose service maps to ServiceEC2 or ServiceCompute (via the existing mapServiceType).
• The PurchaseOptions.OfferingClass value sent to the provider is unchanged.

Recommendations carry no offering class in the pinned library (common.ComputeDetails has none). The class is a purchase-time setting, so this PR leaves the purchase request alone and only fixes the recorded value.

Verification

GOTOOLCHAIN=go1.26.6 GOWORK=off GOFLAGS='-p=2 -count=1' AWS_EC2_METADATA_DISABLED=true

• New tests in internal/purchase/money_path_regression_test.go drive processPurchaseRecommendations with GlobalConfig.OfferingClass set, capture the provider's PurchaseOptions and the saved history row.
• Against origin/main's execution.go:

  --- FAIL: TestOfferingClassStampedOnHistoryMatchesPurchase/standard_legacy_slug     expected: "standard" actual: "convertible"
  --- FAIL: TestOfferingClassStampedOnHistoryMatchesPurchase/standard_canonical_slug  expected: "standard" actual: ""
  --- FAIL: TestOfferingClassStampedOnHistoryMatchesPurchase/unset_means_the_client_default  expected: "convertible" actual: ""
  --- FAIL: TestUnknownOfferingClassRefusesBeforePurchase  An error is expected but got nil.
  

• With the fix: all pass. Mutation probe (stamp literal Convertible again) fails the two standard cases.
• go build ./..., go vet ./..., go vet -tags integration ./internal/...: clean.
• go test ./internal/purchase/ ./internal/api/ ./internal/server/: 3276 passed.
• golangci-lint run ./internal/purchase/...: no issues.

All evidence is mock-based (fixture provider and store); no real purchase was made. No Postgres integration test: the store write path for offering_class is unchanged and already covered by the migration 000087 round-trip test.

Deliberately left

• Existing history rows already stamped "convertible" for Standard RIs are not backfilled. The marketplace handler only re-fetches from AWS when the column is empty, so those rows stay wrong until a backfill or a re-fetch is done. This needs an owner decision.
• The hard-coded "convertible" in the RI exchange handlers (internal/api/handler_ri_exchange.go, internal/server/handler_ri_exchange.go) is correct there, because exchanges only apply to Convertible RIs.

Closes #112

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 4 billable files and costs up to $1.00.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 13 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 50 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: 0d33669d-a3c7-41f6-9df2-05e28e7a90a4

📥 Commits

Reviewing files that changed from the base of the PR and between e65a8a3 and 8b4a9d5.

📒 Files selected for processing (4)

• frontend/src/history.ts
• internal/purchase/coverage_extra_test.go
• internal/purchase/execution.go
• internal/purchase/money_path_regression_test.go

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}