[cristim]

What

reserveAndCreateListing (internal/api/handler_marketplace.go): when AWS created a listing, the DB write of that listing failed, and the compensating CancelMarketplaceListing also failed, the handler still released the claim (restoring the pre-listing fields) and returned "listing has been rolled back". The AWS listing stayed live, the row no longer referenced it, and the released claim allowed another listing to be created.

Fix

Only that branch changes (new helper keepUncanceledListing):

• The claim is not released. The handler writes the known listing ID and AWS state (active) instead, using the existing UpdatePurchaseHistoryListing and listing-state constants. This is the same number of DB writes as before (it replaces the release write). With the listing recorded, marketplace-cancel can cancel it, and ClaimMarketplaceListingSlot blocks a duplicate listing.
• If that write also fails because the DB is still down, the row keeps its pending claim. That claim blocks a duplicate listing, and the message tells the operator to reconcile the listing.
• The response is a 502 ClientError that names the listing ID and the AWS cancel error. This follows the existing mapAWSMarketplaceError 502 pattern. The DB error text is logged and not returned. Previously this path returned a generic 500 that said nothing about rollback.

Unchanged: the path where compensation succeeds (cancel succeeds, claim released, "rolled back"), and the path where create fails.

Verification

Toolchain: GOTOOLCHAIN=go1.26.6 GOWORK=off GOFLAGS='-p=2 -count=1' AWS_EC2_METADATA_DISABLED=true

• New unit test TestMarketplaceList_DBFailureAndCancelFailureKeepsListing (mock store) covers two cases: the listing gets recorded, and the DB stays down. It asserts 502, no "rolled back", the listing ID and AWS error in the message, and no release write ("", "").
• New integration test TestMarketplaceListCancelFailureKeepsListingRecorded uses real Postgres via testcontainers. The store wrapper fails only the first listing write, and the EC2 client is a stub. The test asserts the row holds ril-default/active, a second list attempt is refused without calling AWS create again, and a later successful cancel moves the row to cancelled.
• On the pre-fix handler, both tests fail:

  Messages: listing created but could not be persisted; listing has been rolled back: transient db failure
  --- FAIL: TestMarketplaceListCancelFailureKeepsListingRecorded
  --- FAIL: TestMarketplaceList_DBFailureAndCancelFailureKeepsListing/listing_recorded   mock: Unexpected Method Call
  

• Mutation check: changing the recording write back to the release ("", "") also fails both. The integration test reports expected: "ril-default" actual: "" and "An error is expected but got nil" (a duplicate listing was created). The mutation was then reverted.
• With the fix: go build ./..., go vet ./..., go vet -tags integration ./internal/api/ ./internal/config/ all clean. go test ./internal/api/ ./internal/config/ ./internal/server/: 3640 passed. go test -tags integration ./internal/api/ -run Marketplace: 106 passed. golangci-lint run ./internal/api/...: no issues.

All of this evidence uses mocks or fixtures (stub EC2, injected DB failure). No real AWS listing was created.

Deliberately left

• If AWS returns a non-active state on create (e.g. pending), the recorded row can't be canceled through marketplace-cancel until the status poller (RI Marketplace: status poller (active->closed + proceeds/fee) + seller-account precondition UI (closes #292 remainder) #27) exists. That poller is out of scope here.
• No frontend change. The UI shows the error string as it is, and no frontend code matches "rolled back".
• sec(api): approve/cancel discard an authorization denial and fall through — safe only by coincidence #173 and sec(money): currency is dropped at every layer boundary, so USD-denominated caps are compared against non-USD amounts [platform part] #361 are not touched.

Closes #335

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 3 billable files and costs up to $0.75.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 1 minute for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 50 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: 385755ac-d7f7-4850-b3bc-3a5b4e64c4ff

📥 Commits

Reviewing files that changed from the base of the PR and between 87b8ce8 and a4557a7.

📒 Files selected for processing (3)

• internal/api/handler_marketplace.go
• internal/api/handler_marketplace_compensation_integration_test.go
• internal/api/handler_marketplace_test.go

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}