Repository navigation
docs(terraform): use placeholder buckets in AWS and GCP dev backend examples - #502
Conversation
…xamples The AWS dev example named a bucket in another account; the GCP dev example and README named a bucket that is neither a placeholder nor the CI bucket. Closes #481
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 50 minutes for your next included review. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 52 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughThe AWS and GCP development backend examples now use provider-specific bucket names. The AWS example also updates its state key and identifies the ChangesDevelopment backend examples
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~8 minutes Change: Other · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The changes do not alter CI’s AWS backend path, and the GCP setup documents creating the bucket used by its example. No demonstrated issue blocks merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Replace the wrong-account bucket in
aws/backends/dev.tfbackend.examplewith a placeholder, and do the same for the GCP dev example and README.Why
cudly-terraform-state-devis in AWS account 540659244915, not the deploy account 909626172446. Copying the example for a localterraform initwould hit the wrong account's bucket. The repo is public, and the sibling generictfbackend.examplefiles already useyour-...placeholders, so a placeholder is the consistent choice (unlikeci-cd-permissions/backend.hcl.example, which only the owner runs and which #478 pointed at the real bucket).Change
your-cudly-terraform-state-aws-dev, keygithub-dev/terraform.tfstate(same shape CI writes), comment that CI uses theTF_BACKEND_AWSsecret.gcp/README.md:cudly-terraform-state-devis neither a placeholder nor the CI bucket, so it becomesyour-cudly-terraform-state-gcp-dev.Verification
terraform fmt -checkclean; grep shows no remainingcudly-terraform-state-dev. No plan/apply run.Closes #481
Summary by CodeRabbit
TF_BACKEND_AWSsecret.