[cristim]

Summary

The Savings Plans group parent row on the Opportunities page scaled its savings total with scaleCost and then passed the already-scaled value into formatCostForPeriod, which scales internally. With the cost-period selector on "yearly" a $1,000/mo SP group rendered as $144,000/yr instead of $12,000/yr; on "hourly" it rendered roughly 1/720th of the right figure.

Root cause

frontend/src/recommendations.ts (SP group parent row rendering) computed scaledSpSavings = scaleCost(spSavingsTotal, period) and then called formatCostForPeriod(scaledSpSavings, period), but formatCostForPeriod (line ~1592) already calls scaleCost internally. Every sibling row in the same table passes the raw monthly value into formatCostForPeriod, or uses formatScaledRange (which does not re-scale), so the SP group row was the sole double-scaled outlier. The default period is monthly (factor 1), so the bug was invisible until a user changed the selector, and the only existing test ran at the default period.

Fix

Pass the raw spSavingsTotal directly to formatCostForPeriod and drop the outer scaleCost call.

Regression test

Extended frontend/src/__tests__/recommendations.test.ts's "Issue #135: SP group parent row rendered in table" describe block with a new test asserting the group savings text at period: 'yearly' on a $300/mo SP group total: expects $3600, not the double-scaled $36000.

Proved pre-fix failure: git stash push -- frontend/src/recommendations.ts then ran the new test -- it failed with Expected substring: "$3600" / Received string: "$43200/ yr" (12x too high, matching the double-scale). Restored via git stash pop and reran: passes.

Verification

• npm test -- recommendations.test.ts -- 409 passed
• npx eslint src/recommendations.ts src/__tests__/recommendations.test.ts -- no issues
• npm run build -- webpack production build succeeds (pre-existing entrypoint-size warning only)

Closes #252

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 2 billable files and costs up to $0.50.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 15 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available. Your 30 included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 4dd1f736-69eb-4968-881a-f435558700e5

📥 Commits

Reviewing files that changed from the base of the PR and between 4b7bc93 and a17b7e9.

📒 Files selected for processing (2)

• frontend/src/__tests__/recommendations.test.ts
• frontend/src/recommendations.ts

---

_{Comment @coderabbitai help to get the list of available commands.}

[cristim]

Independent adversarial review + local verification: MERGE at a17b7e9. The backend emits monthly figures and formatCostForPeriod scales internally, so the SP group row now passes raw monthly; every other scaleCost call site verified not to double-scale. Pre-fix test shows $43200/yr for a $300/mo total; passes after; jest 409/409, lint/build OK.