Skip to content

fix(dashboard): call the Active Commitments figure estimated savings #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Nov 4, 2026
Merged

fix(dashboard): call the Active Commitments figure estimated savings #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions frontend/src/__tests__/dashboard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,23 @@ describe('Dashboard Module', () => {
});

describe('loadDashboard', () => {
// #1709: committed_monthly sums the active commitments' estimated monthly
// savings (handler_dashboard.go), not what they cost, so the card must not
// call it "committed".
test('Active Commitments detail names the figure as estimated savings', async () => {
(api.getDashboardSummary as jest.Mock).mockResolvedValue({
total_recommendations: 0, active_commitments: 3, committed_monthly: 500,
current_coverage: 70, target_coverage: 80, ytd_savings: 0, by_service: {},
});
(api.getUpcomingPurchases as jest.Mock).mockResolvedValue({ purchases: [] });

await loadDashboard();

const tile = document.querySelector('#summary [data-kpi="commitments"]');
expect(tile?.textContent).toContain('$500/mo estimated savings');
expect(tile?.textContent).not.toContain('committed');
});

test('fetches dashboard summary and upcoming purchases', async () => {
(api.getDashboardSummary as jest.Mock).mockResolvedValue({
potential_monthly_savings: 1000,
Expand Down
4 changes: 3 additions & 1 deletion frontend/src/dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,10 @@ function renderDashboardSummary(
// #180: count the same rows the range sums (and the Opportunities page
// counts); the backend total ignores the Enabled Providers setting.
detail: `${recsCount ?? data.total_recommendations ?? NO_VALUE} recommendations` },
// #1709: committed_monthly is the active commitments' estimated monthly
// savings, not what they cost.
{ kpi: 'commitments', title: 'Active Commitments', value: data.active_commitments != null ? String(data.active_commitments) : NO_VALUE,
detail: `${formatCurrency(data.committed_monthly)}/mo committed` },
detail: `${formatCurrency(data.committed_monthly)}/mo estimated savings` },
{ kpi: 'coverage', title: 'Current Coverage', value: coverageValue, detail: coverageDetail },
{ kpi: 'ytd', title: 'YTD Savings', value: formatCurrency(data.ytd_savings), valueSavings: true,
detail: 'From commitment purchases' },
Expand Down
3 changes: 3 additions & 0 deletions internal/api/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6771,6 +6771,9 @@ components:
committed_monthly:
type: number
format: double
description: >-
Estimated monthly savings of the active commitments (the sum of
their estimated savings), not what the commitments cost.
current_coverage:
type: number
format: double
Expand Down
4 changes: 3 additions & 1 deletion internal/api/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,9 @@ type DashboardSummaryResponse struct {
PotentialMonthlySavings float64 `json:"potential_monthly_savings"`
TotalRecommendations int `json:"total_recommendations"`
ActiveCommitments int `json:"active_commitments"`
CommittedMonthly float64 `json:"committed_monthly"`
// CommittedMonthly is the estimated monthly savings of the active
// commitments (the sum of their EstimatedSavings), not their cost (#1709).
CommittedMonthly float64 `json:"committed_monthly"`
// CurrentCoverage is null when there is neither committed nor potential
// savings to measure (0/0), instead of a fabricated 100% (issue #72).
CurrentCoverage *float64 `json:"current_coverage"`
Expand Down
Loading