[cristim]

Closes #201.

Problem: the migrate-aws concurrency comment in .github/workflows/database-migration.yml (~269-272) says an evicted queued migration "leaves the run green". That's false. Eviction cancels the queued job, and a run containing a cancelled job concludes cancelled, not success. #201 has the evidence: across about 700 runs, a cancelled job never coexisted with a success run conclusion.

Change (comment only): the clause now says the evicted job ends cancelled, so the run concludes cancelled, and that the summary job (if: always(), needing all three migrate jobs) still runs and prints the per-cloud results. The eviction fact and the other bullet are unchanged.

The issue's longer replacement text, a rewrite of the whole ~40-line block, isn't applied here. The block's other statements are still accurate, so this PR fixes only the false clause.

Local: actionlint passes on the file and pre-commit passes. No workflow logic changes.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation
  • Clarified that an AWS migration run evicted while queued ends as cancelled, rather than appearing successful.
  • Documented that the summary job still runs and reports results for each cloud.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: LeanerCloud/cloud-commitments-platform
• Branch: docs/migration-eviction-comment
• File: .coderabbit.yaml
• Commit: 135a497
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Essentials
• Run ID: 14013e45-b1f4-4b79-810f-416859f473d7

Commits

Reviewing files that changed from the base of the PR and between 5d86714 and 135a497.

Files selected for processing: 1

• .github/workflows/database-migration.yml

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

The workflow comment now states that evicting a queued migration leaves the run cancelled. It also notes that the always() summary job still prints per-cloud results.

Changes: Migration concurrency documentation

Layer / File(s)	Summary
Clarify migration run outcome .github/workflows/database-migration.yml	The comment replaces the claim that an evicted queued migration leaves the run green. It states that the run is cancelled and that the summary job still prints per-cloud results.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other · Severity of issue fixed: Low

Suggested reviewers: iamjsd

Merge Risk: Minimal · up to 135a4

This documentation-only correction is ready to merge.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title states the main change: a documentation fix in the CI workflow saying an evicted migration ends the run as cancelled rather than green. The changeset is a comment-only edit to .github/workfl…
Linked Issues check		Issue #201 requires a comment-only correction to the false claim that an evicted queued migration leaves the run green. The diff changes only the concurrency comment in `.github/workflows/database-mig…
Out of Scope Changes check		The whole-PR diff contains only three changed comment lines in .github/workflows/database-migration.yml. The diff does not change job declarations, expressions, concurrency groups, or workflow steps…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…

Full details: Title check

Explanation

The title states the main change: a documentation fix in the CI workflow saying an evicted migration ends the run as cancelled rather than green. The changeset is a comment-only edit to .github/workflows/database-migration.yml that corrects this claim, and the title's wording matches the linked issue #201 objective. The title is specific and accurate, though the 'docs(ci)' prefix and 64-character length are slightly longer than ideal.

Full details: Linked Issues check

Explanation

Issue #201 requires a comment-only correction to the false claim that an evicted queued migration leaves the run green. The diff changes only the concurrency comment in .github/workflows/database-migration.yml. It states that the evicted job ends cancelled, the run concludes cancelled, and the summary job still runs and prints per-cloud results. The concurrency declaration and workflow logic remain unchanged. No coding test requirement applies to this comment-only change.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff contains only three changed comment lines in .github/workflows/database-migration.yml. The diff does not change job declarations, expressions, concurrency groups, or workflow steps. The comment correction and its clarification of summary behavior directly support issue #201. No unrelated change is present.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[cristim]

Independent review 2 (claude-fleet, cold): APPROVE 135a497

Scope: comment-only, .github/workflows/database-migration.yml (+3/-3), the concurrency note on migrate-aws (:264-274). No YAML keys change.

Findings: none blocking.

• The GitHub concurrency docs ("Control the concurrency of workflows and jobs") state the job-level half: "any existing pending job or workflow in the same concurrency group will be canceled." They do not spell out the run-level conclusion. A run with a cancelled job concluding cancelled matches GitHub's run semantics, but linking an observed run in docs(ci): database-migration concurrency comment claims an evicted migration leaves the run green, which is false #201 (or citing the job and run conclusion docs) would make the claim checkable. [non-blocking]

Checked:

• The old comment was wrong for the reason the new one gives. An evicted pending migrate job is cancelled, not skipped or succeeded, so the run cannot be green. The summary job does not need to exit 1 for that.
• summary (:638-644) declares needs: [validate, migrate-aws, migrate-gcp, migrate-azure] and if: always(), so it runs after a cancelled needs job and prints RESULT_AWS, RESULT_GCP and RESULT_AZURE from needs.<job>.result (:652 onward). That matches "still runs and prints the per-cloud results".
• The same eviction applies to migrate-gcp (:430-432) and migrate-azure (:541-543), which point back to this note ("reasoning documented on migrate-aws"), so one corrected comment covers all three.
• The rest of the note (cancel-in-progress false, the environment-approval caveat) is unchanged and still accurate.

Reviewed by an independent agent with no author context (second reviewer). Review only: nothing was pushed, and the GitHub review state is unchanged.

[cristim]

VERDICT: APPROVE 135a497
Findings: no actionable findings.

• Non-blocking: docs(ci): database-migration concurrency comment claims an evicted migration leaves the run green, which is false #201 also suggests trimming the ~40-line block ("Second, smaller issue"); this PR fixes only the false clause yet says "closes docs(ci): database-migration concurrency comment claims an evicted migration leaves the run green, which is false #201". Owner call whether the trim is still wanted.
  Checked (at 135a497, database-migration.yml):
• Job-level concurrency on migrate-aws: L238 job, L275-277 concurrency: group db-migrate-aws-..., cancel-in-progress: false (L277); gcp L430-432, azure L541-543 same shape.
• summary: L643 needs: [validate, migrate-aws, migrate-gcp, migrate-azure], L644 if: always(), prints RESULT_AWS/GCP/AZURE (L652-654); never exits non-zero, so "still runs and prints" is accurate.
• Eviction => cancelled: matches docs(ci): database-migration concurrency comment claims an evicted migration leaves the run green, which is false #201 body evidence (109/109 runs of this shape concluded cancelled, 0 success).
• Rest of block not contradicted: dropping "Unlike rollback.yml" removes the only claim tied to the false inference; the cancel-in-progress and reviewer-binding bullets are unaffected.
• git diff -U0 origin/main 135a497d has 3+/3- lines, all # comments; branch is based on current origin/main.
• actionlint (~/go/bin/actionlint) on the file at head: exit 0, no output.

[cristim]

Local verification at 135a497d27d794030ef9a8fadef9f8dbe62116b1 merged onto current main (5d86714f; merge-tree d69faaa7; macOS):

• actionlint (when workflows changed), shellcheck on the changed scripts and every changed scripts/test-*.sh pass on the merged tree.
• Nothing was applied to any cloud.