Skip to content

Follow-ups from #963 review: '}' and JSON metacharacters in the Bicep/ARM contact email #991

Closed

Description

@IAmJSD

#963 (issue #958) merged at 7a71710. Its independent review left these non-blocking notes on internal/iacfiles/templates/azure-wif-bicep-deploy.sh.tmpl:

  1. A } in the email closes ${CUDLY_CONTACT_EMAIL:-...} early and reorders the value. This is not injection.
  2. The self-registration heredoc puts ${CONTACT_EMAIL} straight into the JSON, so an email containing " or \ gives a malformed payload.

Note 3 (newlines on comment lines) is already tracked in #970.

The same ${CUDLY_CONTACT_EMAIL:-{{.ContactEmail}}} pattern and raw heredoc JSON also appear in 8 other templates: aws-cfn-deploy, aws-cross-account-cfn-deploy, aws-cross-account-cli, aws-wif-cli, azure-wif-cli, azure-wif-deploy, gcp-sa-impersonation-cli and gcp-wif-cli. Those aren't covered here and could get one follow-up that reuses the same pattern and test helper.

🤖 Generated with Claude Code

Activity

  1. self-assigned this
    on Oct 16, 2026
  2. IAmJSD commented on Oct 16, 2026

    @IAmJSD
    CollaboratorAuthor

    Claiming: working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions