You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Follow-ups from #963 review: '}' and JSON metacharacters in the Bicep/ARM contact email #991
#963 (issue #958) merged at 7a71710. Its independent review left these non-blocking notes on internal/iacfiles/templates/azure-wif-bicep-deploy.sh.tmpl:
A } in the email closes ${CUDLY_CONTACT_EMAIL:-...} early and reorders the value. This is not injection.
The self-registration heredoc puts ${CONTACT_EMAIL} straight into the JSON, so an email containing " or \ gives a malformed payload.
Note 3 (newlines on comment lines) is already tracked in #970.
The same ${CUDLY_CONTACT_EMAIL:-{{.ContactEmail}}} pattern and raw heredoc JSON also appear in 8 other templates: aws-cfn-deploy, aws-cross-account-cfn-deploy, aws-cross-account-cli, aws-wif-cli, azure-wif-cli, azure-wif-deploy, gcp-sa-impersonation-cli and gcp-wif-cli. Those aren't covered here and could get one follow-up that reuses the same pattern and test helper.
Activity
IAmJSD commentedon Oct 16, 2026
Claiming: working on this