You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(frontend): RI exchange refresh after an exchange drops the account chip scope #918
Found during the independent review of #915 (#162). This predates that PR.
After an exchange completes, frontend/src/riexchange.ts (~:1916, post-exchange refresh) calls loadConvertibleRIs() with no accountID. With an account chip selected, the refreshed list is therefore unscoped, and it shows every account's convertible RIs until the next full load.
Suggested fix: refresh through the same resolved scope (currentRIAccountID, or loadRIExchange()), and add a jest test that a post-exchange refresh keeps account_id.
Closing as already fixed by #1126 (merged as a9e5475, the fix for the duplicate #285). On main a14dc8f, the post-exchange refresh calls loadRIExchange() (frontend/src/riexchange.ts:1947), which keeps the account chip scope. The jest test this issue asks for already exists at frontend/src/tests/riexchange.test.ts:1062.
Activity
IAmJSD commentedon Oct 24, 2026
Closing as already fixed by #1126 (merged as a9e5475, the fix for the duplicate #285). On main a14dc8f, the post-exchange refresh calls
loadRIExchange()(frontend/src/riexchange.ts:1947), which keeps the account chip scope. The jest test this issue asks for already exists at frontend/src/tests/riexchange.test.ts:1062.