Skip to content

fix(frontend): RI exchange refresh after an exchange drops the account chip scope #918

Closed

Description

@cristim

Found during the independent review of #915 (#162). This predates that PR.

After an exchange completes, frontend/src/riexchange.ts (~:1916, post-exchange refresh) calls loadConvertibleRIs() with no accountID. With an account chip selected, the refreshed list is therefore unscoped, and it shows every account's convertible RIs until the next full load.

Suggested fix: refresh through the same resolved scope (currentRIAccountID, or loadRIExchange()), and add a jest test that a post-exchange refresh keeps account_id.

Related: #162, #915.

Activity

  1. IAmJSD commented on Oct 24, 2026

    @IAmJSD
    Collaborator

    Closing as already fixed by #1126 (merged as a9e5475, the fix for the duplicate #285). On main a14dc8f, the post-exchange refresh calls loadRIExchange() (frontend/src/riexchange.ts:1947), which keeps the account chip scope. The jest test this issue asks for already exists at frontend/src/tests/riexchange.test.ts:1062.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions