You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(history): count a recommendation as AWS only when its provider says so in the duplicate-warning gate #1725
Review note on #1712. The duplicate-purchase warning gate (IsDefiniteAWSRefusal, internal/purchase/errsummary.go) treats a recommendation with an empty Provider as AWS. Only all-AWS executions with a definite AWS 4xx refusal drop the warning. So an execution whose recs have no provider recorded, in a stored row from an older writer, could have the warning dropped on AWS-shaped text alone.
Expected
The gate counts a rec as AWS only when its provider is explicitly aws. An empty provider keeps the warning.
Notes
This is a one-line change in the gate plus a test case for an empty provider. Today the warning is kept anyway, because the gate does not yet match the executor's stored AWS wrapper (see the #1694 item 3 note), so the change has no visible effect yet. Related: #1694, #1712, #1721.
Activity
fix(history): recognize the executor's stored AWS refusals in the dup…