Skip to content

fix(api): editing an in-progress non-preset weekly/monthly plan is refused as a ramp change #1184

Closed

Description

@cristim

Summary

Saving an in-progress plan whose stored ramp is a non-preset weekly or monthly (for example weekly 20%/7d, created through the API) fails with 409 "cannot change the ramp schedule", even when only the name changes.

Evidence (origin/main with #1183)

Before #1183 the form sent immediate for these plans, which also returned 409, so this is not a regression; #1183 made the behaviour visible.

Proposed fix

Treat two ramps as the same shape when percent, interval and total steps match, whatever the type label is, or keep the stored type when an equivalent custom ramp is submitted. Add handler tests for:

  • a rename of an in-progress weekly 20% plan succeeds and keeps its progress;
  • a real change of percent or interval is still refused.

Found by review of #1183.

Activity

  1. IAmJSD commented on Oct 20, 2026

    @IAmJSD
    Collaborator

    Claiming: working on this

  2. self-assigned this
    on Oct 20, 2026
  3. added a commit that references this issue on Oct 23, 2026
    a14dc8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions