Skip to content

fix(ladder): tranche storage precision and refusing tranches without a CommitmentRate #1182

Closed

Description

@cristim

Split out from LeanerCloud/cloud-commitments-go#354 (the go side is done: AWS SP commitments are range-checked and truncated to 5 decimals in #403, and the precision contract is documented at pkg/ladder/capability.go:62-74 in #438).

Two items remain for the platform tranche path:

  1. Tranche commitments are stored as float64 in NUMERIC(20,6). Confirm that the stored precision round-trips the provider precision contract.
  2. When the tranche executor lands, it must refuse old tranches stored without a CommitmentRate rather than defaulting.

Platform main has no tranche executor yet, so item 2 is a design constraint for that work. See platform#118.

Activity

  1. IAmJSD commented on Oct 20, 2026

    @IAmJSD
    Collaborator

    Claiming: working on this

  2. self-assigned this
    on Oct 20, 2026
  3. IAmJSD commented on Oct 27, 2026

    @IAmJSD
    Collaborator

    Closing: both items are fixed on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions