Skip to content

fix(exchange): show unknown-outcome auto-exchanges as needing reconciliation in the notification email #1055

Closed

Description

@cristim

Found during the independent review of #1053, which bumps cloud-commitments-go to 3def3f8.

Since go#497/#499, an auto-exchange whose accept outcome is unknown stays in AutoExchangeResult.Failed with OutcomeUnknown=true. go keeps the ledger record non-failed, so it still counts against the daily cap, and the run halts (go pkg/exchange/auto.go:577-584).

The platform ignores the flag. buildExchangeNotificationData (internal/server/handler_ri_exchange.go:201-224) copies only Error, so the notification email lists the exchange as failed. The error text says "purchase outcome unknown", so the email is not wrong, but it does not tell the operator to reconcile before acting.

Ask: carry OutcomeUnknown into the notification data, and render unknown-outcome exchanges in their own "verify in AWS / reconcile" group, separate from real failures. Add a test with an unknown-outcome result.

Activity

  1. IAmJSD commented on Oct 23, 2026

    @IAmJSD
    Collaborator

    Claiming: working on this

  2. self-assigned this
    on Oct 23, 2026
  3. added a commit that references this issue on Oct 25, 2026
    408ea79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions