[cristim]

Summary

• Re-pin providers/azure and providers/aws to the fix(recfilter): dedupe each term and payment variant against the full held quantity #714 merge (pkg@81a709068bba), so the provider modules dedupe each term and payment variant against the full held quantity.
• Restore TestHeldReservation_VariantPin in providers/azure/services/managedredis, now asserting 1, 1, 1, 1.

Evidence

• Fail-before: with the old pin under GOWORK=off the restored test fails (actual 1, 2, 2, 2); with the new pin it passes, also through go.work.
• GOWORK=off go test -short ./... passes for providers/azure and providers/aws; golangci-lint reports 0 issues on both.
• go mod tidy also raised two indirect requirements that pkg needs (aws-sdk-go-v2 v1.47.5, smithy-go v1.28.7).
• Staged diff reviewed cold in two passes: no actionable findings.

Not in scope

• providers/gcp still pins pkg from before fix(recfilter): dedupe each term and payment variant against the full held quantity #714 and imports pkg/recfilter; chore(providers): re-pin pkg past #714 and restore the managedredis variant dedupe test #723 names only azure and aws.

Closes #723

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: LeanerCloud/cloud-commitments-go
• Branch: chore/723-repin-recfilter
• File: .coderabbit.yaml
• Commit: f1237f9
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 691a232c-4895-4d38-b6cf-f9d071da9fc0

Commits

Reviewing files that changed from the base of the PR and between 9c0d25c and f1237f9.

Files ignored due to path filters: 2

• providers/aws/go.sum is excluded by !**/*.sum
• providers/azure/go.sum is excluded by !**/*.sum

Files selected for processing: 3

• providers/aws/go.mod
• providers/azure/go.mod
• providers/azure/services/managedredis/held_reservation_dedupe_test.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[cristim]

APPROVE @ f1237f9 by claude-nibblets

Cold review of #727 (closes #723, +35/-12, a pin bump plus one restored test; 0 behind main).

• Pin: providers/azure and providers/aws now require pkg at v0.0.0-20261109130250-81a709068bba. That commit exists and is on main (81a7090, "fix(recfilter): dedupe each term and payment variant against the full held quantity", fix(recfilter): dedupe each term and payment variant against the full held quantity #714).
• go.sum: all 6 distinct added lines (the new pkg and go.mod hashes, aws-sdk-go-v2 v1.47.5, smithy-go v1.28.7) match sum.golang.org; go mod verify reports all modules verified in both modules. The two indirect bumps in providers/azure/go.mod are what pkg now requires, as the PR says.
• Fail-before, which I ran: with the new pin (GOWORK=off) TestHeldReservation_VariantPin passes; with the base commit's go.mod and go.sum restored it fails with the 1, 2, 2, 2 pattern (the counts show 2). So the restored test pins the pin.
• Suites at this head (GOWORK=off, -short): providers/aws builds and all 15 test packages pass; providers/azure has 14 passing packages and no FAIL line.
• Noted, not in scope per the PR: providers/gcp still pins a pkg from before fix(recfilter): dedupe each term and payment variant against the full held quantity #714 and imports pkg/recfilter, so it still has the old variant dedupe; if chore(providers): re-pin pkg past #714 and restore the managedredis variant dedupe test #723 only names azure and aws, a GCP follow-up should be filed.

CI at this head: 14 pass, 1 skipping; CI Success and Run pre-commit hooks pass.