fix(providers): mark reported costs as known and stop inventing Azure inventory region and state

providers/aws/ladder/commitments.go

@@ -74,6 +74,9 @@ func (a *AWSLadder) listRICommitments(ctx context.Context) ([]common.Commitment,
 // FixedPrice) are per-instance, so the per-instance hourly rate is multiplied
 // by InstanceCount. See riHourlyCost for the formula and semantics (matches the
 // repo's canonical monthlyCostFromConvertibleRI in internal/api/handler_ri_exchange.go).
+//
+// CostKnown requires a Duration: riHourlyCost skips upfront amortization without
+// one, so the total would be incomplete.
 func riToCommitment(ri *ec2svc.ConvertibleRI, accountID, region string) common.Commitment {
 	totalHourlyCost := riHourlyCost(ri)
 
@@ -90,6 +93,7 @@ func riToCommitment(ri *ec2svc.ConvertibleRI, accountID, region string) common.C
 		StartDate:      ri.Start,
 		EndDate:        ri.End,
 		Cost:           totalHourlyCost,
+		CostKnown:      ri.Duration > 0,
 	}
 }
 
@@ -140,5 +144,6 @@ func spToCommitment(sp *ActiveSP, accountID string) common.Commitment {
 		StartDate:      sp.StartDate,
 		EndDate:        sp.EndDate,
 		Cost:           sp.HourlyCommitmentUSD,
+		CostKnown:      true,
 	}
 }

providers/aws/ladder/commitments_test.go

@@ -0,0 +1,45 @@
+package ladder
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+
+	ec2svc "github.com/LeanerCloud/cloud-commitments-go/providers/aws/services/ec2"
+)
+
+func TestRIToCommitment_FullyUpfrontWithDurationIsKnown(t *testing.T) {
+	t.Parallel()
+	ri := &ec2svc.ConvertibleRI{
+		ReservedInstanceID: "ri-1",
+		InstanceCount:      2,
+		FixedPrice:         8760,
+		Duration:           31536000, // one year in seconds
+	}
+
+	got := riToCommitment(ri, "123456789012", "us-east-1")
+
+	assert.True(t, got.CostKnown)
+	assert.Greater(t, got.Cost, 0.0)
+}
+
+func TestRIToCommitment_NoDurationIsUnknown(t *testing.T) {
+	t.Parallel()
+	// Without a duration the upfront part cannot be amortized, so the
+	// computed cost is incomplete and must not be claimed as known.
+	ri := &ec2svc.ConvertibleRI{ReservedInstanceID: "ri-1", InstanceCount: 2, FixedPrice: 8760}
+
+	got := riToCommitment(ri, "123456789012", "us-east-1")
+
+	assert.False(t, got.CostKnown)
+}
+
+func TestSPToCommitment_ZeroHourlyCommitmentIsKnown(t *testing.T) {
+	t.Parallel()
+	sp := &ActiveSP{PlanID: "sp-1", PlanType: spPlanTypeCompute, HourlyCommitmentUSD: 0}
+
+	got := spToCommitment(sp, "123456789012")
+
+	assert.True(t, got.CostKnown)
+	assert.Zero(t, got.Cost)
+}

providers/aws/services/ec2/client_test.go

@@ -278,6 +278,30 @@ func TestClient_GetExistingCommitments(t *testing.T) {
 	}
 }
 
+func TestClient_GetExistingCommitments_CostIsUnknown(t *testing.T) {
+	t.Parallel()
+	mockClient := &MockEC2Client{}
+	mockClient.On("DescribeReservedInstances", mock.Anything, mock.Anything).
+		Return(&ec2.DescribeReservedInstancesOutput{
+			ReservedInstances: []types.ReservedInstances{{
+				ReservedInstancesId: aws.String("ri-123"),
+				InstanceType:        types.InstanceTypeT3Micro,
+				InstanceCount:       aws.Int32(1),
+				State:               types.ReservedInstanceStateActive,
+				Duration:            aws.Int64(31536000),
+				Start:               aws.Time(time.Now()),
+			}},
+		}, nil).Once()
+	client := &Client{client: mockClient, region: "us-east-1"}
+
+	result, err := client.GetExistingCommitments(context.Background())
+
+	assert.NoError(t, err)
+	if assert.Len(t, result, 1) {
+		assert.False(t, result[0].CostKnown)
+	}
+}
+
 func TestClient_GetValidResourceTypes(t *testing.T) {
 	t.Parallel()
 	tests := []struct {

providers/azure/go.mod

@@ -15,16 +15,16 @@ require (
 	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armsubscriptions v1.3.0
 	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/search/armsearch v1.4.0
 	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/sql/armsql v1.2.0
-	github.com/LeanerCloud/cloud-commitments-go/pkg v0.0.0-20261104063122-3efa339480ac
+	github.com/LeanerCloud/cloud-commitments-go/pkg v0.0.0-20261106184548-8d06fde536cf
 	github.com/stretchr/testify v1.12.1
 	golang.org/x/sync v0.24.0
 )
 
 require (
 	github.com/Azure/azure-sdk-for-go/sdk/internal v1.13.0 // indirect
 	github.com/AzureAD/microsoft-authentication-library-for-go v1.10.1 // indirect
-	github.com/aws/aws-sdk-go-v2 v1.47.4 // indirect
-	github.com/aws/smithy-go v1.28.6 // indirect
+	github.com/aws/aws-sdk-go-v2 v1.47.5 // indirect
+	github.com/aws/smithy-go v1.28.7 // indirect
 	github.com/golang-jwt/jwt/v5 v5.3.1 // indirect
 	github.com/google/uuid v1.6.0 // indirect
 	github.com/kylelemons/godebug v1.1.0 // indirect

providers/azure/go.sum

@@ -36,12 +36,12 @@ github.com/AzureAD/microsoft-authentication-extensions-for-go/cache v0.1.1 h1:WJ
 github.com/AzureAD/microsoft-authentication-extensions-for-go/cache v0.1.1/go.mod h1:tCcJZ0uHAmvjsVYzEFivsRTN00oz5BEsRgQHu5JZ9WE=
 github.com/AzureAD/microsoft-authentication-library-for-go v1.10.1 h1:0O6j18nQDoIff6/mtosT5LNU2WehEwp+LqfX6699oqY=
 github.com/AzureAD/microsoft-authentication-library-for-go v1.10.1/go.mod h1:xdYAf5bjkOpsd3auA8riiJW4vneBubt9caavL7626jQ=
-github.com/LeanerCloud/cloud-commitments-go/pkg v0.0.0-20261104063122-3efa339480ac h1:EvEUCt1uH5oBtPcJJPt1mX6XYQWAKtL9QBSo9CfeaOw=
-github.com/LeanerCloud/cloud-commitments-go/pkg v0.0.0-20261104063122-3efa339480ac/go.mod h1:pseCFRgm1rzBKomktjw6E0ayxmVE7XfHHiOmew4ka+g=
-github.com/aws/aws-sdk-go-v2 v1.47.4 h1:bTvk6UdSSSvaQsfLVj1JRDEEqj/PDRwGf1KanaRzau0=
-github.com/aws/aws-sdk-go-v2 v1.47.4/go.mod h1:XkrjAZvr705Nytv6PkPUhoSB2W9+vVHBp5oAWpkh8Ak=
-github.com/aws/smithy-go v1.28.6 h1:Pj+/sUviNYjow8ELRtNwKHZ9ECeF+7pATX3+shjLIrw=
-github.com/aws/smithy-go v1.28.6/go.mod h1:YE2RhdIuDbA5E5bTdciG9KrW3+TiEONeUWCqxX9i1Fc=
+github.com/LeanerCloud/cloud-commitments-go/pkg v0.0.0-20261106184548-8d06fde536cf h1:uKewFUeWwrvgoBaFeZMepJXs+xsQdqTVRomAc6tYMX8=
+github.com/LeanerCloud/cloud-commitments-go/pkg v0.0.0-20261106184548-8d06fde536cf/go.mod h1:l9V+ecJCfAigYr6XiK9kpIUemF9bnXOKHJN1s4TPsM0=
+github.com/aws/aws-sdk-go-v2 v1.47.5 h1:5yA+A+BiXbDq1ZLbYwPViwhEGDMdR0MEhL8Jh2LnLS4=
+github.com/aws/aws-sdk-go-v2 v1.47.5/go.mod h1:iNIkogrRvFwm+1OQIUOP2lPBtlXZboOIUWiCa+pHEMw=
+github.com/aws/smithy-go v1.28.7 h1:h/n1SHrwVtaDYLz8mR1/Kq4Xh4RaFbFW7bOYckg9mfE=
+github.com/aws/smithy-go v1.28.7/go.mod h1:YE2RhdIuDbA5E5bTdciG9KrW3+TiEONeUWCqxX9i1Fc=
 github.com/golang-jwt/jwt/v5 v5.3.1 h1:kYf81DTWFe7t+1VvL7eS+jKFVWaUnK9cB1qbwn63YCY=
 github.com/golang-jwt/jwt/v5 v5.3.1/go.mod h1:fxCRLWMO43lRc8nhHWY6LGqRcf+1gQWArsqaEUEa5bE=
 github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=

providers/azure/services/cache/client.go

@@ -186,8 +186,6 @@ func (c *Client) convertRedisReservation(detail *armconsumption.ReservationDetai
 		Account:        c.subscriptionID,
 		CommitmentType: common.CommitmentReservedInstance,
 		Service:        common.ServiceCache,
-		Region:         c.region,
-		State:          common.CommitmentStateActive,
 	}
 
 	if props.ReservationID != nil {

providers/azure/services/cache/client_test.go

@@ -16,6 +16,7 @@ import (
 	"github.com/LeanerCloud/cloud-commitments-go/pkg/common"
 	azpricing "github.com/LeanerCloud/cloud-commitments-go/providers/azure/internal/pricing"
 	"github.com/LeanerCloud/cloud-commitments-go/providers/azure/mocks"
+	"github.com/LeanerCloud/cloud-commitments-go/providers/azure/services/internal/reservations/reservationstest"
 )
 
 // MockReservationsDetailsPager mocks the ReservationsDetailsPager interface.
@@ -861,3 +862,32 @@ func TestNewClientWithHTTP_NilFallbackIsHardened(t *testing.T) {
 	require.Error(t, err, "nil-fallback client must reject IMDS connections")
 	assert.Contains(t, err.Error(), "blocked")
 }
+
+func TestCacheClient_GetExistingCommitments_DoesNotInventRegionOrState(t *testing.T) {
+	t.Parallel()
+	for _, region := range []string{"eastus", "westeurope"} {
+		t.Run(region, func(t *testing.T) {
+			t.Parallel()
+			client := NewClient(nil, "test-subscription", region)
+			reservationID, skuName := "res-1", "redis-premium-p1"
+			client.SetReservationsPager(&MockReservationsDetailsPager{
+				pages: []armconsumption.ReservationsDetailsClientListResponse{{
+					ReservationDetailsListResult: armconsumption.ReservationDetailsListResult{
+						Value: []*armconsumption.ReservationDetail{{
+							Properties: &armconsumption.ReservationDetailProperties{
+								ReservationID: &reservationID,
+								SKUName:       &skuName,
+							},
+						}},
+					},
+				}},
+			})
+
+			commitments, err := client.GetExistingCommitments(context.Background())
+
+			require.NoError(t, err)
+			require.Len(t, commitments, 1)
+			reservationstest.AssertUnknownInventory(t, commitments[0])
+		})
+	}
+}

providers/azure/services/cosmosdb/client.go

@@ -285,8 +285,6 @@ func (c *Client) convertCosmosReservation(detail *armconsumption.ReservationDeta
 		Account:        c.subscriptionID,
 		CommitmentType: common.CommitmentReservedInstance,
 		Service:        common.ServiceNoSQL,
-		Region:         c.region,
-		State:          common.CommitmentStateActive,
 	}
 
 	if props.ReservationID != nil {

providers/azure/services/cosmosdb/client_test.go

@@ -21,6 +21,7 @@ import (
 
 	"github.com/LeanerCloud/cloud-commitments-go/pkg/common"
 	"github.com/LeanerCloud/cloud-commitments-go/providers/azure/mocks"
+	"github.com/LeanerCloud/cloud-commitments-go/providers/azure/services/internal/reservations/reservationstest"
 )
 
 // MockRecommendationsPager mocks the RecommendationsPager interface.
@@ -1768,3 +1769,32 @@ func TestGetCosmosPricing_LegitimateSKUBuildsExactFilter(t *testing.T) {
 	assert.Equal(t, "serviceName eq 'Azure Cosmos DB' and productName eq 'Azure Cosmos DB' and armRegionName eq 'Global' and armSkuName eq 'Cosmos_DB_100_RUs' and priceType eq 'Reservation'", req.URL.Query().Get("$filter"))
 	mockHTTP.AssertExpectations(t)
 }
+
+func TestCosmosDBClient_GetExistingCommitments_DoesNotInventRegionOrState(t *testing.T) {
+	t.Parallel()
+	for _, region := range []string{"eastus", "westeurope"} {
+		t.Run(region, func(t *testing.T) {
+			t.Parallel()
+			client := NewClient(nil, "test-subscription", region)
+			reservationID, skuName := "res-1", "cosmos-db-standard"
+			client.SetReservationsPager(&MockReservationsDetailsPager{
+				pages: []armconsumption.ReservationsDetailsClientListResponse{{
+					ReservationDetailsListResult: armconsumption.ReservationDetailsListResult{
+						Value: []*armconsumption.ReservationDetail{{
+							Properties: &armconsumption.ReservationDetailProperties{
+								ReservationID: &reservationID,
+								SKUName:       &skuName,
+							},
+						}},
+					},
+				}},
+			})
+
+			commitments, err := client.GetExistingCommitments(context.Background())
+
+			require.NoError(t, err)
+			require.Len(t, commitments, 1)
+			reservationstest.AssertUnknownInventory(t, commitments[0])
+		})
+	}
+}

providers/azure/services/database/client.go

@@ -341,8 +341,6 @@ func (c *Client) convertSQLReservation(detail *armconsumption.ReservationDetail)
 		Account:        c.subscriptionID,
 		CommitmentType: common.CommitmentReservedInstance,
 		Service:        common.ServiceRelationalDB,
-		Region:         c.region,
-		State:          common.CommitmentStateActive,
 	}
 
 	if props.ReservationID != nil {

providers/azure/services/database/client_test.go

@@ -22,6 +22,7 @@ import (
 	"github.com/LeanerCloud/cloud-commitments-go/pkg/common"
 	azpricing "github.com/LeanerCloud/cloud-commitments-go/providers/azure/internal/pricing"
 	"github.com/LeanerCloud/cloud-commitments-go/providers/azure/mocks"
+	"github.com/LeanerCloud/cloud-commitments-go/providers/azure/services/internal/reservations/reservationstest"
 )
 
 // MockRecommendationsPager mocks the RecommendationsPager interface.
@@ -2196,3 +2197,32 @@ func TestNewClientWithHTTP_NilFallbackIsHardened(t *testing.T) {
 	require.Error(t, err, "nil-fallback client must reject IMDS connections")
 	assert.Contains(t, err.Error(), "blocked")
 }
+
+func TestDatabaseClient_GetExistingCommitments_DoesNotInventRegionOrState(t *testing.T) {
+	t.Parallel()
+	for _, region := range []string{"eastus", "westeurope"} {
+		t.Run(region, func(t *testing.T) {
+			t.Parallel()
+			client := NewClient(nil, "test-subscription", region)
+			reservationID, skuName := "res-1", "sql-standard-s0"
+			client.SetReservationsPager(&MockReservationsDetailsPager{
+				pages: []armconsumption.ReservationsDetailsClientListResponse{{
+					ReservationDetailsListResult: armconsumption.ReservationDetailsListResult{
+						Value: []*armconsumption.ReservationDetail{{
+							Properties: &armconsumption.ReservationDetailProperties{
+								ReservationID: &reservationID,
+								SKUName:       &skuName,
+							},
+						}},
+					},
+				}},
+			})
+
+			commitments, err := client.GetExistingCommitments(context.Background())
+
+			require.NoError(t, err)
+			require.Len(t, commitments, 1)
+			reservationstest.AssertUnknownInventory(t, commitments[0])
+		})
+	}
+}

providers/azure/services/internal/reservations/inventory.go

@@ -224,11 +224,8 @@ func appliedOrderIDs(resp armreservations.AzureReservationAPIClientGetAppliedRes
 // The SDK exposes PurchaseDate at day precision, so this cannot establish
 // whether a purchase yesterday occurred within the last 24 hours.
 //
-// Cost stays at zero. The reservations API carries no per-reservation price,
-// so zero here means "unknown", not "free". The shared common.Commitment.Cost
-// scalar has no absent-value representation (tracked by issue #62); the only
-// in-repo consumer of GetExistingCommitments (the pkg/recfilter
-// DuplicateChecker) never reads Cost, so the zero value is harmless there.
+// Cost is unknown: the reservations API carries no per-reservation price, so
+// CostKnown stays false and a zero Cost must not be read as free.
 func CommitmentFromReservation(r *armreservations.ReservationResponse, account string, service common.ServiceType, wantType armreservations.ReservedResourceType, now time.Time) *common.Commitment {
 	if r == nil || r.Properties == nil {
 		return nil

providers/azure/services/internal/reservations/reservationstest/inventory.go

@@ -0,0 +1,22 @@
+package reservationstest
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+
+	"github.com/LeanerCloud/cloud-commitments-go/pkg/common"
+)
+
+// AssertUnknownInventory asserts that c carries only what the consumption
+// ReservationDetail API reports: no region, state, price, quantity or start
+// date. Producers built on that API must not invent these from the client.
+func AssertUnknownInventory(t *testing.T, c common.Commitment) {
+	t.Helper()
+	assert.Empty(t, c.Region, "region is not in ReservationDetail")
+	assert.Empty(t, c.State, "state is not in ReservationDetail")
+	assert.False(t, c.CostKnown)
+	assert.Zero(t, c.Cost)
+	assert.Zero(t, c.Count)
+	assert.True(t, c.StartDate.IsZero())
+}

providers/azure/services/savingsplans/client.go

@@ -304,6 +304,7 @@ func convertSavingsPlan(sp *armbillingbenefits.SavingsPlanModel, subscriptionID
 
 		if props.Commitment != nil && props.Commitment.Amount != nil {
 			commitment.Cost = *props.Commitment.Amount
+			commitment.CostKnown = true
 		}
 	}
 

providers/azure/services/savingsplans/client_test.go

@@ -907,3 +907,52 @@ func TestPurchaseCommitment_NonCurrencyErrorIsNotCurrencyRefusal(t *testing.T) {
 	require.Error(t, err)
 	assert.NotErrorIs(t, err, common.ErrCurrencyNotAccepted)
 }
+
+func TestConvertSavingsPlan_CostKnown(t *testing.T) {
+	t.Parallel()
+	now := time.Now().UTC()
+	zero, rate := 0.0, 2.5
+	plan := func(c *armbillingbenefits.Commitment) *armbillingbenefits.SavingsPlanModel {
+		return &armbillingbenefits.SavingsPlanModel{
+			ID:  toPtr("/subscriptions/sub/savingsPlans/sp1"),
+			SKU: &armbillingbenefits.SKU{Name: toPtr("Compute_Savings_Plan")},
+			Properties: &armbillingbenefits.SavingsPlanModelProperties{
+				EffectiveDateTime: &now,
+				Commitment:        c,
+			},
+		}
+	}
+	tests := []struct {
+		name      string
+		commit    *armbillingbenefits.Commitment
+		wantKnown bool
+		wantCost  float64
+	}{
+		{"zero amount is known", &armbillingbenefits.Commitment{Amount: &zero}, true, 0},
+		{"reported amount is known", &armbillingbenefits.Commitment{Amount: &rate}, true, 2.5},
+		{"nil amount is unknown", &armbillingbenefits.Commitment{}, false, 0},
+		{"nil commitment is unknown", nil, false, 0},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+			got, err := convertSavingsPlan(plan(tt.commit), "sub")
+			require.NoError(t, err)
+			assert.Equal(t, tt.wantKnown, got.CostKnown)
+			assert.Equal(t, tt.wantCost, got.Cost)
+		})
+	}
+}
+
+func TestConvertSavingsPlan_NilPropertiesIsRejected(t *testing.T) {
+	t.Parallel()
+	sp := &armbillingbenefits.SavingsPlanModel{
+		ID:  toPtr("/subscriptions/sub/savingsPlans/sp1"),
+		SKU: &armbillingbenefits.SKU{Name: toPtr("Compute_Savings_Plan")},
+	}
+
+	got, err := convertSavingsPlan(sp, "sub")
+
+	require.Error(t, err)
+	assert.Nil(t, got, "no commitment is returned, so no cost can be claimed known")
+}

providers/azure/services/search/client.go

@@ -204,8 +204,6 @@ func (c *Client) convertSearchReservation(detail *armconsumption.ReservationDeta
 		Account:        c.subscriptionID,
 		CommitmentType: common.CommitmentReservedInstance,
 		Service:        common.ServiceSearch,
-		Region:         c.region,
-		State:          common.CommitmentStateActive,
 	}
 
 	if props.ReservationID != nil {