[cristim]

Summary

Part 2 of #277, the Azure side. Part 1 (#447, b69a17e) added common.Commitment.StartDateIsDay and the day-resolution check in the recent-commitment duplicate guard.

The two commits are kept separate so the pin bump can be judged on its own:

1. build(azure) bumps the azure pkg pin from v0.0.0-20261012192523-3838efd56668 to v0.0.0-20261016163842-4566498f2a08.
   • It pulls in these pkg commits that touch packages azure imports: b69a17e, 498b74f, 77bc8a9, 6fd189f, 9551cce, e9a33bb and cdcdc7f.
   • Azure sees them only through DuplicateChecker. The one behaviour change there is fix(recfilter): coverage drop reason, EC2 platform engine filter, money scaling on dedupe #379's common.ResizeCount: a partial overlap now scales cost and savings, and a source count of 0 or less is an error.
   • The full azure build and race suite passed on the bumped pin before any code change.
2. fix(azure) sets StartDateIsDay = true in the shared reservation inventory (providers/azure/services/internal/reservations/inventory.go), where StartDate comes from the date-only PurchaseDate.
   • armreservations v1.1.0 / API 2022-03-01 uses format: date.
   • All seven reservation clients go through this one function.
   • The Savings Plans path uses the date-time EffectiveDateTime and stays precise, and a test now pins that.

Effect: a reservation bought late yesterday now suppresses a matching duplicate recommendation. Before, it decoded to UTC midnight and looked older than the 24h window.

Wire shape: Azure reservation commitments now serialize "start_date_is_day":true.

Closes #277

Verification (macOS, Go 1.26.9)

Commands

• (cd providers/azure && GOWORK=off go test -race -short ./...): pass.
• make build, make vet: pass.
• golangci-lint v2.10.1 (CI pin): 0 issues.
• gofmt, gocyclo -over 10: clean.

SDK-decode regression (compute/purchase_date_guard_sdk_test.go)

• Real reservation JSON goes through the SDK pager and GetExistingCommitments, then NewDuplicateChecker(24).AdjustRecommendationsForExisting, using the real clock.
• If the UTC date changes mid-run, the test skips rather than fail.
• Cases:
  • Filtered: today, yesterday.
  • Passed: two days ago; canceled yesterday (excluded by state); expired yesterday (excluded by state).

Fail-before: without the inventory line, purchased_yesterday fails.

Other tests

• TestPurchaseDateGuardSDKPartialOverlapScalesCosts: existing 1 against recommended 3 gives count 2, and cost, on-demand and savings scale by 2/3. This pins the fix(recfilter): coverage drop reason, EC2 platform engine filter, money scaling on dedupe #379 change the pin bump brings in.
• The inventory unit test asserts the flag.
• The Savings Plans TestGetExistingCommitments_Happy asserts the flag is false. Forcing it on fails the test.

Review

• The plan had two passes by a non-author reviewer.
• The same reviewer did two diff passes. Pass 1 led to the Savings Plans guard.
• No actionable findings on the final series.
• Rebased onto 512e42f and re-tested.

All of this uses SDK-shaped fixtures. No Azure call or purchase was made.

🤖 Generated with Claude Code

[cristim]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 5 billable files and costs up to $1.25.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 6 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 65 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: 4a47fc46-6f7f-4bb6-93d8-4f56e6b88db4

📥 Commits

Reviewing files that changed from the base of the PR and between ae6fbfe and 21b70e0.

⛔ Files ignored due to path filters: 1

• providers/azure/go.sum is excluded by !**/*.sum

📒 Files selected for processing: 5

• providers/azure/go.mod
• providers/azure/services/compute/purchase_date_guard_sdk_test.go
• providers/azure/services/internal/reservations/inventory.go
• providers/azure/services/internal/reservations/inventory_test.go
• providers/azure/services/savingsplans/client_test.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[cristim]

Independent review verdict: CLEAN at c2849d2

Reviewer: fresh Claude agent (Sonnet, high effort), not the author, cold brief. The PR body was treated as a claim. Coordinator: claude-cc-reviewer.

Blocking findings: none.

SDK (armreservations v1.1.0, module cache):

• PurchaseDate is a *time.Time (models.go:591), decoded by unpopulateDateType (models_serde.go:1818) with layout "2006-01-02" (date_type.go:22,32-35). So "2026-10-16" becomes 00:00 UTC.
• A malformed value errors (date_type.go:50-57), and the pager error propagates out of ListAppliedReservations. A parse failure therefore fails closed.

The guard:

• go.mod bumps only the pkg pin, to 4566498, which carries StartDateIsDay handling (pkg/recfilter/dedupe.go:116-119: midnight + 24h compared against the cutoff).
• The PR sets the flag at inventory.go:268-269.
• So a date-only purchase is treated as the latest possible moment of that day:

Case	Result
Purchased today, any time	Duplicate blocked
Purchased 23:30 UTC yesterday, seen 20:00 UTC today (the bug)	Blocked
Purchased 2 days ago	Not blocked
Exactly at the cutoff	Not blocked, since After is strict (acceptable)
Canceled or expired	Excluded before the date check
Unknown or empty state	Counted as owned (fails closed)

Consumers:

• All 7 reservation clients go through CommitmentFromReservation (internal/reservations/strict.go:30): compute, database, cache, search, cosmosdb, synapse and managedredis.
• Savings Plans (savingsplans/client.go:259) use the date-time EffectiveDateTime, so they stay precise. The test asserts the flag is false there.

Non-blocking, already present before this PR: a nil PurchaseDate leaves StartDate zero, so the row looks ancient and the guard fails open. Filed as #454.

What was attacked and how (providers/azure, GOWORK=off, no Azure calls):

• go vet ./... is clean. go test -race -count=1 ./... gives 12 ok and 0 FAIL.
• Fail-before: with inventory.go reverted to main, TestCommitmentFromReservation_StartDateUsesPurchaseDate and TestPurchaseDateGuardSDKDateOnlyPurchase/purchased_yesterday fail.
• Mutation probes, both killed:
  • setting the flag to false (the same 2 tests fail);
  • shifting StartDate by -24h (3 tests fail).

Gate: labels are mirrored from #277. Merge once CI is green at this SHA.

[cristim]

CI is green on head c2849d2e: pre-commit 38937839183 and Build & Test 38937839205.

[cristim]

Pure rebase onto main after go#446 merged. git range-diff of c2849d2 against new head 21b70e0 shows identical commits (=), so the CLEAN verdict carries. (claude-cc-reviewer)