Repository navigation
feat(common): add ExperimentalGCPPlanTerm to RecommendationParams - #402
Merged
Merged
Conversation
Opt-in flag, default false, for the GCP Compute plan-derived CUD term (go#291). Split from go#401 so provider modules can bump the pkg pin. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 4 minutes for your next included review. View limit details
Comment |
Member
Author
|
Gate verdict at head
|
cristim
added a commit
that referenced
this pull request
Oct 16, 2026
Moves providers/azure from pkg 3838efd to 4566498 so the module sees common.Commitment.StartDateIsDay and the recfilter change from b69a17e. pkg commits in between that touch packages azure imports: b69a17e fix(recfilter): treat a date-only commitment start as any time that d... 498b74f feat(common): preserve proven commitment currency metadata (#410) 77bc8a9 feat(common): add ExperimentalGCPPlanTerm to RecommendationParams (#402) 6fd189f fix(recfilter): coverage drop reason, EC2 platform engine filter, mon... 9551cce fix(scorer): compute break-even so --max-break-even-months filters e9a33bb feat(pkg): add recurring monthly cost to the audit record cdcdc7f feat(common): add RecommendationParams.SPAccountScope (step 1 of 2) Azure build and race tests pass on the bumped pin before any code change. Refs #277 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cristim
added a commit
that referenced
this pull request
Oct 16, 2026
…duplicate guard (#453) * build(azure): bump pkg pin to include the date-only start guard Moves providers/azure from pkg 3838efd to 4566498 so the module sees common.Commitment.StartDateIsDay and the recfilter change from b69a17e. pkg commits in between that touch packages azure imports: b69a17e fix(recfilter): treat a date-only commitment start as any time that d... 498b74f feat(common): preserve proven commitment currency metadata (#410) 77bc8a9 feat(common): add ExperimentalGCPPlanTerm to RecommendationParams (#402) 6fd189f fix(recfilter): coverage drop reason, EC2 platform engine filter, mon... 9551cce fix(scorer): compute break-even so --max-break-even-months filters e9a33bb feat(pkg): add recurring monthly cost to the audit record cdcdc7f feat(common): add RecommendationParams.SPAccountScope (step 1 of 2) Azure build and race tests pass on the bumped pin before any code change. Refs #277 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(azure): mark reservation purchaseDate as a calendar date The reservations API returns purchaseDate as a date, so a reservation bought late yesterday decoded to 00:00 UTC yesterday and fell outside the 24h duplicate guard. Set StartDateIsDay so the guard treats the instant as anywhere in that day. Adds an SDK-decode regression through DuplicateChecker with the real clock, and a partial-overlap test that checks ResizeCount scales the recommendation costs. Refs #277 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds only the
RecommendationParams.ExperimentalGCPPlanTermfield (default false, EXPERIMENTAL doc comment). No behavior change: nothing reads it yet.Split from #401 so providers/gcp can bump its pkg pin before consuming the field (standalone module CI builds with GOWORK=off). Refs #291.
🤖 Generated with Claude Code