fix(azure): land Advisor field derivation and Synapse collection (recovers #378, #382)

[cristim]

Closes #292
Refs #47 (wires Synapse only; Search and Managed Redis stay unwired, reasons in the issue comment).
Refs #252 (Advisor page cap only; the subscription cap and other uncapped pagers stay open)

This recovers content that was approved at 462df7e (#378) and 87db9c8 (#382) but was merged into stacked branches by mistake instead of main. #366 and #373 are already on main; this branch is origin/fix/292-azure-advisor-derive-fields with origin/main merged in. The only conflicts were against the squashed #366, resolved to its content plus the follow-up changes from #378/#382.

Contents

• Advisor conversion derives commitment type, term, currency, SKU and quantity from the payload; resize/shutdown and unmapped reservation types are ignored; unknown or missing values are recorded skips surfaced via PartialResultError; page cap and page errors surface the same way.
• Advisor Savings Plan rows use ServiceSavingsPlansAll and are dropped when the Benefit Recommendations client returned an SP row for the same (account, term).
• Synapse is collected under ServiceDataWarehouse. Search (no valid Consumption type, no retail rows) and Managed Redis (same RedisCache type as the cache client, would duplicate rows) are deliberately not wired.

Verification (fixture-based)

GOWORK=off go vet ./... && go test ./... in providers/azure pass; GOWORK=off go build ./... of pkg, providers/aws, providers/gcp and providers/azure pass; pre-commit gocyclo passes. git diff origin/main...HEAD touches only: providers/azure/internal/recommendations/consumption.go, pagination_cap_test.go, recommendations.go, recommendations_advisor_test.go, recommendations_test.go.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 5 billable files and costs up to $1.25.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 53 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: dd6bea67-38a2-4816-8ba3-82eeda4815d7

📥 Commits

Reviewing files that changed from the base of the PR and between a60dfce and 676b9e8.

📒 Files selected for processing: 5

• providers/azure/internal/recommendations/consumption.go
• providers/azure/pagination_cap_test.go
• providers/azure/recommendations.go
• providers/azure/recommendations_advisor_test.go
• providers/azure/recommendations_test.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[cristim]

Independent review (claude-opus-5-5) of 676b9e8: APPROVE

This PR recovers #378 + #382, which the gate merged into their stacked bases instead of main. Review only.

1. The content matches the approved changes. In providers/azure outside services/savingsplans, main (a60dfce) is byte-identical to fix(azure): surface skipped consumption recommendations as a typed partial-result error #366's approved head 2de6006. At 080944e, git diff origin/main 080944e -- providers/azure was identical to git diff 2de6006 87db9c8 -- providers/azure, the union of my approved fix(azure): derive Advisor fields from the payload and fail loud on truncation #378 (462df7e) and fix(azure): collect Synapse recommendations in the provider fan-out #382 (87db9c8). The diff touches no file outside providers/azure, and services/savingsplans (feat(azure/savingsplans): implement Savings Plan recommendations from benefitRecommendations #373) is identical to main.
2. Nothing from fix(azure): surface skipped consumption recommendations as a typed partial-result error #366 was reverted. The PartialResultError alias, AsPartialResult and the partial branch in mergeSubscriptionResults are present. TestMultiSubscriptionRecommendationsClient_PartialResultKeepsRecommendations and TestGetRecommendations_NonUSDSkipIsSurfaced pass.
3. The lint-fix delta 080944e..676b9e8 is mechanical:
   • range-by-index in dropCoveredAdvisorSavingsPlans;
   • %v to %w for the page error (errors.Is(err, errAdvisorTruncated) still holds, so collectAdvisorOrSkip behaves the same);
   • the unused ctx dropped from advisorPurchaseKind.
4. Local evidence (fresh clone, macOS): go vet and go test -count=1 ./... in providers/azure pass, and GOWORK=off go build ./... passes for pkg, providers/aws, providers/azure and providers/gcp.
5. CI: every check on 676b9e8 is green, including Lint Code (providers/azure), Unit Tests and Integration Tests. The PR is mergeable.

The non-blocking notes from my #378/#382 reviews still apply: Advisor rows repeat per lookback period, and PropagatesContextCancellation still builds real clients on a canceled context.