Skip to content

chore(providers): re-pin pkg past #714 and restore the managedredis variant dedupe test #723

Closed

Description

@cristim

Context

#714 (merged as 81a7090) makes pkg/recfilter dedupe each term and payment variant against the full held quantity (#703). Providers only pick it up when their pkg pin moves to that merge. Until then the over-buy (one held unit reducing only the first variant) still happens through the provider modules.

That PR also removed TestHeldReservation_VariantPin from providers/azure/services/managedredis/held_reservation_dedupe_test.go. It asserted the old 1, 2, 2, 2 behaviour, and CI runs the provider modules both through go.work (new pkg) and with GOWORK=off (pinned pkg), so no single assertion could pass both.

Work

Order

After any other provider PR that bumps pkg, to avoid re-pin conflicts.

Activity

  1. cristim commented on Nov 9, 2026

    @cristim
    MemberAuthor

    Claimed by claude-qa-ui-4: re-pin providers/azure and providers/aws past #714, restore the managedredis variant test, and check the other recfilter-variant tests under GOWORK=off. I will rebase the pin onto whichever provider PR (#712, #713) merges first, as the Order section asks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions