Skip to content

fix(azure/savingsplans): purchase path sends PlanType "Compute" as sku.name; the API expects Compute_Savings_Plan #387

Closed

Description

@cristim

savingsplans.Client.PurchaseCommitment and buildValidateBody set SKU.Name to SavingsPlanDetails.PlanType. GetValidResourceTypes advertises "Compute"/"MachineLearning", and the new recommendations (#371, PR #373) also use "Compute". The Benefit Recommendations API names the SKU Compute_Savings_Plan (armSkuName), which is what the SavingsPlanOrderAlias sku.name expects.

Needs a decision on the PlanType vocabulary (map at purchase time vs. carry the ARM SKU name in the details). Not changed in #373. Verify against the SavingsPlanOrderAlias docs before changing; no purchase call should be made to test it.

Activity

  1. IAmJSD commented on Oct 17, 2026

    @IAmJSD
    Collaborator

    Claiming: working on this

  2. added a commit that references this issue on Oct 18, 2026
    d13a0d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions