Repository navigation
fix(recfilter): dedupe reduces Count without scaling cost and savings; add shared ResizeCount helper #370
Description
adjustSingleRecommendation (pkg/recfilter/dedupe.go ~260) sets Count to the remaining count but leaves CommitmentCost, OnDemandCost, EstimatedSavings, RecurringMonthlyCost at full-count values. Same pattern as the CLI extended-support cut (cmd/multi_service_engine_versions.go ~497), a sibling of closed CLI #1830/#1844. Related: #323 (dedupe key dimensions, not addressed here).
Fix: add common.ResizeCount(rec, n) that scales via ScaleRecommendationCosts by n/rec.Count and errors on a non-positive source count; use it in dedupe. The CLI cut can reuse it after the go.mod bump.
Activity
fix(recfilter): coverage drop reason, EC2 platform engine filter, mon…
IAmJSD commentedon Oct 15, 2026
Released: this turned out to be already fixed on main (details in the comment below), so I'm not working on it.
IAmJSD commentedon Oct 15, 2026
Releasing my claim: this is already fixed. #379 (merged 2026-10-13 as 6fd189f,
Refs #370) addedcommon.ResizeCountand uses it in dedupe;TestAdjustRecommendationsForExisting_PartialCoverageScalesMoneyfails on the pre-#379 dedupe and passes on main. The CLI half is done too:cmd/multi_service_engine_versions.goalready callscommon.ResizeCount, and the CLI's go.mod pin (9b35837) contains 6fd189f. I think this can be closed.IAmJSD commentedon Oct 15, 2026
@cristim could you close this one? It was fixed by #379 (which used
Refsrather thanCloses, so it stayed open).cristim commentedon Oct 16, 2026
Checked against main
740dfbd: #379 (6fd189f) addedcommon.ResizeCount(pkg/common/resize.go:14) and the duplicate checker uses it. It usedRefs, so this stayed open. Marking needs-info for a close decision.cristim commentedon Oct 17, 2026
Closing as completed per owner decision (2026-10-17): fixed by #379 (6fd189f, common.ResizeCount used by the dedupe). That PR said 'Refs' instead of 'Closes', so this stayed open.