Repository navigation
fix(recfilter): engine filters ignore the EC2 Platform shown as Engine #369
Description
Filters.IncludesEngine uses common.EngineFromDetails, which returns '' for *ComputeDetails. The CSV labels EC2 Platform as Engine, but --include-engines 'Windows (Amazon VPC)' yields 0 recs and --exclude-engines windows leaves 22 of 22.
Fix: engine filters match the normalised EC2 Platform (case-insensitive, '(Amazon VPC)' suffix optional) without changing EngineFromDetails, which feeds the dedupe key and Matches.
Activity
fix(recfilter): coverage drop reason, EC2 platform engine filter, mon…
cristim commentedon Oct 16, 2026
Checked against main
740dfbd: #379 (6fd189f, second commit) addedEngineFilterKeyso engine filters match the EC2 platform. It usedRefs #369, so this stayed open. Marking needs-info for a close decision.cristim commentedon Oct 20, 2026
Verified on current main. #379 added common.EngineFilterKey (pkg/common/engine.go:125-145), which uses the normalised EC2 Platform for compute and leaves EngineFromDetails untouched; Filters uses it at pkg/recfilter/filters.go:81-83. filters_test.go:244-250 cover 'Windows (Amazon VPC)', bare 'windows', 'linux' and exclude-windows, case-insensitively. [claude-cc-libs]