Repository navigation
chore(terraform): remove committed tfplan.lt + gitignore plan files - #1099
Conversation
…ary commits Commit afea1b7fa accidentally committed a binary Terraform plan file (terraform/environments/aws/ci-cd-permissions/tfplan.lt, 26 KB) that can contain sensitive resource and state details. Root cause: .gitignore had `tfplan` (exact name) and `*.tfplan` (suffix), but not `tfplan.*`, so `tfplan.lt` slipped through. Add the missing patterns to both the root .gitignore and terraform/.gitignore: - `tfplan.*` catches plan files with arbitrary extensions (e.g. .lt, .out) - `*.tfplan.*` catches double-extension variants (e.g. foo.tfplan.gz) The binary artifact itself (tfplan.lt) must be removed from any branch that carries afea1b7fa before that branch merges; see the linked issue.
cristim
added
triaged
|
Warning Review limit reached
More reviews will be available in 51 minutes and 58 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
…ary commits (#1099) Commit afea1b7fa accidentally committed a binary Terraform plan file (terraform/environments/aws/ci-cd-permissions/tfplan.lt, 26 KB) that can contain sensitive resource and state details. Root cause: .gitignore had `tfplan` (exact name) and `*.tfplan` (suffix), but not `tfplan.*`, so `tfplan.lt` slipped through. Add the missing patterns to both the root .gitignore and terraform/.gitignore: - `tfplan.*` catches plan files with arbitrary extensions (e.g. .lt, .out) - `*.tfplan.*` catches double-extension variants (e.g. foo.tfplan.gz) The binary artifact itself (tfplan.lt) must be removed from any branch that carries afea1b7fa before that branch merges; see the linked issue.
Summary
tfplan.*and*.tfplan.*gitignore patterns to both.gitignoreandterraform/.gitignoreto prevent Terraform plan binaries from being committed.afea1b7fa, which accidentally committedterraform/environments/aws/ci-cd-permissions/tfplan.lt(26,944 bytes) -- a build artifact that can contain sensitive resource and state details.Closes #1098
Root cause
The existing
.gitignorehadtfplan(exact name) and*.tfplan(suffix), but nottfplan.*, sotfplan.ltslipped through. The file itself is only present on thefix/706-partially-completed-chipbranch (introduced byafea1b7fa). That branch must remove the file viagit rm terraform/environments/aws/ci-cd-permissions/tfplan.ltbefore it merges intofeat/multicloud-web-frontend.gitignore rules added
In
.gitignoreandterraform/.gitignore:After this PR,
git check-ignore -v terraform/environments/aws/ci-cd-permissions/tfplan.ltcorrectly matchesterraform/.gitignore:37:tfplan.*.Test plan
git check-ignore -v terraform/environments/aws/ci-cd-permissions/tfplan.ltreturns a matchafea1b7faremovestfplan.ltviagit rmbefore merging