You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Opportunities page: Total Recommendations (6) and Showing-X-of-X (23) disagree #748
On the Opportunities page the two recommendation counts disagree:
KPI card at the top: Total Recommendations: 6
Filter row below: Showing 23 of 23 recommendations
Same dataset, same filter ("All Providers / All Accounts"), different numbers.
Why both numbers exist
The table groups variants under a parent row (e.g. Standard_D2as_v4 — 4 variants). With the current data there are 6 parent groups summing to 4+4+4+4+2+5 = 23 variants. So:
The KPI counts parent rows (services / SKUs).
"Showing X of X" counts variants (each combination of term + payment + region).
Why it's a bug
Users don't know the codebase's internal grouping; they see "6" in big numbers and "23 of 23" two lines below and conclude something is off. The Home page also shows "23 recommendations" -- matching the variant count, not the KPI -- which compounds the confusion (see linked issue for the Home KPI bug).
Fix direction
Pick one consistent number and label clearly, e.g.:
Option A: KPI shows the variant count (23) and the "Showing of" matches it. Drop "Total Recommendations: 6" or relabel as "Services: 6 / Recommendations: 23".
Option B: Both numbers count parent rows (6). Update "Showing X of X" to count expanded groups.
Option A is closer to how users likely think about purchases (one variant = one purchase row in the cart). Recommend A.
Files likely involved
frontend/src/opportunities.ts (or wherever the KPI + table count are computed)
The variant-grouping happens in the data layer; verify which count the KPI consumes.
Verification
After fix:
Open Opportunities with no filter, then with a Provider filter, then with an Account filter -- the KPI and "Showing of" should always match.
Cross-check with the Home page recommendation count -- they should agree.
Verified shipped: PR #756 (commit c5d0ff6, merged 2026-05-27) is in feat/multicloud-web-frontend. recommendations.ts KPI count now uses variant count to match 'Showing X of X'; tests updated in recommendations.test.ts.
Activity
fix(opportunities): align Total Recommendations KPI with Showing-of c…
cristim commentedon May 28, 2026
Verified shipped: PR #756 (commit c5d0ff6, merged 2026-05-27) is in feat/multicloud-web-frontend. recommendations.ts KPI count now uses variant count to match 'Showing X of X'; tests updated in recommendations.test.ts.