Skip to content

test(cmd): expect DropCoverageSizedToZero for --coverage floor drops on the pkg bump #2195

Closed

Description

@cristim

go#379 (closing cloud-commitments-go#368) moves recfilter.ApplyCoverage floor-to-zero drops from common.DropTargetSizedToZero to the new common.DropCoverageSizedToZero (--coverage-sized-to-zero). It also records drops when coverage is <= 0.

cmd/helpers_test.go:385-397 (TestApplySizing_LegacyCoverageRecordsCountsFlooredToZero) still asserts DropTargetSizedToZero. With pkg replaced by the go#379 head, go test ./cmd/ fails only that test:

"Dropped 1 recs: --coverage-sized-to-zero=1" does not contain "target-sized-to-zero"

Fix in the pkg bump PR: expect common.DropCoverageSizedToZero there. Also check user-facing docs that mention the drop summary for --coverage.

Refs LeanerCloud/cloud-commitments-go#368, LeanerCloud/cloud-commitments-go#379.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions