test(cli): TestRecommendationCompletenessCommand/savingsplans-database/api-error is flaky in CI #2140

Summary

The integration subtest TestRecommendationCompletenessCommand/savingsplans-database/api-error (cmd/recommendation_completeness_test.go, added in #2130) failed once in CI on a docs-only PR branch, then passed on a rerun of semantically identical code.

Evidence

• Failed: run 37624743342 on fc23e47 (PR docs(cli): add legacy Compute Admin migration checklist to GCP setup #2137, docs-only diff to docs/cli/cloud-setup.md), --- FAIL: TestRecommendationCompletenessCommand/savingsplans-database/api-error (1.26s).
• Passed: run 37625552805 on 82cdc92 (same branch, docs-only delta).
• Main is green at the shared base ad57326 (run 37615190817).

A docs-only change cannot affect this test, so the failure indicates nondeterminism in the test or its fixtures (timing, map iteration order, or simulated API-error propagation).

Expected behaviour

The subtest is deterministic: same inputs, same verdict, every run.

Suggested investigation

• Run the subtest in a loop with -count=50 -shuffle=on locally to reproduce.
• Check for map-order dependence in the synthetic operation counts logged by the test (synthetic operations=map[...]) and for timing assumptions in the api-error path.