Repository navigation
feat: the set without arbitrage that carries a constraint null also carries a given measure, or an arbitrage charges that measure #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 proof-quality — request_changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 naming — request_changes
claude/claude-opus-5-5The new theorem's name says it produces a nonzero measure, but
Qis an input and what the statement produces is weightsρwhose combination is positive on a set thatQcharges.LMLExplore/EValues/ConstraintNull/CompleteClass.lean:462— Inexists_measurableSet_noArbitrageOn_or_exists_measure_ne_zero, the suffixexists_measure_ne_zeroreads as an existential over a nonzero measure. The statement actually quantifies over weightsρ : ι → ℝand ends withQ {x | 0 < ∑ i, ρ i * g i x} ≠ 0for the givenQ. The module-doc bullet at line 70 repeats the name. Fix: Rename the existential after the sum, e.g.exists_measurableSet_noArbitrageOn_or_exists_measure_setOf_sum_mul_pos_ne_zero, or more brieflyexists_measurableSet_noArbitrageOn_or_exists_sum_mul_pos, and update the module-doc bullet to match.Reply in this thread to contest a finding; that re-runs only this rubric and posts an answer here. (To fix it, just push a commit — that re-reviews on its own. To contest again after an answer, post a NEW reply rather than editing an old one.)
claude/claude-opus-5-5· 21s · 53.6k in (36.7k cache read, 16.9k cache write) / 1.9k out tokens · reviewing this diff · rubric ·