Repository navigation
refactor: one MGF domination predicate on a set of parameters - #191
Merged
lmlexplore-automation[bot] merged 3 commits intoNov 6, 2026
Merged
lmlexplore-automation[bot] merged 3 commits into
lmlexplore-automation[bot] merged 3 commits into
Conversation
MGFDominatedAbove and MGFDominatedBelow become MGFDominatedOn X P Y Q Λ, domination at every t ∈ Λ: the upper tail uses Set.Ici 0, the lower tail Set.Iic 0, two-sided statements Set.univ. The pairs of lemmas merge (neg, trans, IdentDistrib, the independent sums, the bridge to HasMGFBound), the sums no longer need a sign condition, and the two-sided consumers take one hypothesis hν instead of hν_above and hν_below. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RemyDegenne
commented
Nov 6, 2026
Contributor
Author
AI review — approvedEach rubric is judged independently by multiple review agents; the PR merges only once every rubric is green — any rubric that is not green (changes requested, blocked, errored, stale, or not yet run) blocks the merge. See the rubrics.
♻️ = approved on an earlier commit, re-run before merge. Reviewing this diff at head |
Add mgfDominatedOn_union, MGFDominatedOn.union and MGFDominatedOn.univ_of_Iic_of_Ici, so that the one-sided producers on Set.Ici 0 and Set.Iic 0 reach the two-sided consumers on Set.univ. Co-Authored-By: Claude Code <noreply@github.com>
…d-on # Conflicts: # LMLExplore/Probability/Moments/MGF/Dominated.lean
Merged
via the queue into
LeanMachineLearning:main
with commit Nov 6, 2026
c74895f
21 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MGFDominatedAboveandMGFDominatedBelowbecome a single predicate,MGFDominatedOn X P Y Q Λ: domination at every parametert ∈ Λ. Domination above is the caseΛ = Set.Ici 0, domination below the caseSet.Iic 0, and two-sided statements useSet.univ. The set of parameters is namedΛ, as inHasMGFBound(#188).Probability/Moments/MGF/Dominated.lean:MGFDominatedOnis the old structure witht ∈ Λin place of0 ≤ tort ≤ 0, so the meaning is unchanged, including whenQis not a probability measure.mono, a new lemma: domination onΛimplies domination on every subset;mgfDominatedOn_union(aniff),MGFDominatedOn.unionandMGFDominatedOn.univ_of_Iic_of_Ici, new: domination onΛ ∪ Λ'is domination onΛand onΛ', so the one-sided producers onSet.Ici 0andSet.Iic 0combine into theSet.univhypothesis of the two-sided consumers;neg, generalized:-Xis dominated by-Yon-Λ;trans;IdentDistrib.mgfDominatedOn, for everyΛ.integrable_exp_mul_sum_of_mgfDominatedOn,mgf_sum_le_pow_of_mgfDominatedOn) are one pair instead of two, for anyt ∈ Λ, with no sign condition. The proof only usest ≠ 0, so the lower-tail version no longer goes throughneg.t ∈ Λtogether with0 ≤ t(upper tail) ort ≤ 0(lower tail).Bridge to
HasMGFBound:mgfDominatedAbove_iff_hasMGFBoundandmgfDominatedBelow_iff_hasMGFBoundbecome one lemma,mgfDominatedOn_iff_hasMGFBound : MGFDominatedOn X P Y Q Λ ↔ HasMGFBound X (cgf Y Q) (Λ ∩ integrableExpSet Y Q) P.Producers:
mgfDominatedOn_Ici_bernoulliMeasure(mean at mostq) andmgfDominatedOn_Iic_bernoulliMeasure(mean at leastq). They have different hypotheses on the mean, so they stay two lemmas.GaussianThreshold.leanbecomes one lemma onSet.univ.Consumers:
Set.Ici 0orSet.Iic 0.hν : … Set.univinstead ofhν_aboveandhν_below: forced exploration, D- and C-tracking, the deviations of empirical means, and the Track-and-Stop theorems.No old name remains, and there are no aliases. The docstrings say "dominated on
Set.Ici 0" and so on.The companion roadmap change, LeanMachineLearning/LMLRoadmaps#15, updates the names that the Identification and Bandits roadmaps cite.
Checked locally:
lake build --iofail;#lint in LMLExploreover the 10 changed modules passes.Roadmap: Identification
🤖 Generated with Claude Code