fix(ltk_texture): use image_dds for BC1/BC3 TEX decode, fix Dds::heig…#115
Open
FrogCsLoL wants to merge 1 commit intoLeagueToolkit:mainfrom
Open
fix(ltk_texture): use image_dds for BC1/BC3 TEX decode, fix Dds::heig…#115FrogCsLoL wants to merge 1 commit intoLeagueToolkit:mainfrom
FrogCsLoL wants to merge 1 commit intoLeagueToolkit:mainfrom
Conversation
alanpq
requested changes
Mar 7, 2026
alanpq
requested changes
Mar 7, 2026
Contributor
alanpq
left a comment
alanpq
left a comment
There was a problem hiding this comment.
do a local check before requesting review again
Contributor
Author
|
idk how to use github |
alanpq
approved these changes
Mar 7, 2026
Contributor
|
can you squash allat back into the first commit before merge |
…ht() - Replace texture2ddecoder BC1/BC3 decode with image_dds (already a dep) to fix corrupted/black pixels caused by wrong pixel format assumptions - Add Rgba8Owned variant to TexSurfaceData for direct RGBA passthrough - Add ImageDds(#[from] image_dds::error::SurfaceError) to DecodeErr - Fix Dds::height() returning width instead of height
FrogCsLoL
force-pushed
the
fix/ltk-texture-bc1-bc3-decode
branch
from
52bb0e8 to
c321fb2
Compare
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tex to png and dds to png causing black spots
this should fix it, tested it.