Skip to content

fix: incorrect jvm argument copied on Windows - #11

Merged
aoqia194 merged 3 commits into
LeafPZ:mainfrom
Stikulzon:fix-windows-arg
Oct 14, 2026
Merged

aoqia194 merged 3 commits into
LeafPZ:mainfrom
Stikulzon:fix-windows-arg

Conversation

@Stikulzon

Copy link
Copy Markdown
Contributor

Installer provide a wrong argument for windows

@aoqia194

Copy link
Copy Markdown
Member

Isn't agentlib relative path and agentpath is absolute? I don't want absolute paths, as the user should be able to reference it relative to the game jar.

@aoqia194 aoqia194 self-assigned this Oct 14, 2026
@aoqia194 aoqia194 added priority/medium Can wait a while without impacting other things risk/low Contains almost no risk of breaking labels Oct 14, 2026
@aoqia194 aoqia194 changed the title Fix windows jvm argument fix: incorrect jvm argument copied on Windows Oct 14, 2026
@aoqia194 aoqia194 added this to Global Oct 14, 2026
@github-project-automation github-project-automation Bot moved this to triage in Global Oct 14, 2026
@aoqia194 aoqia194 moved this from triage to review in Global Oct 14, 2026
@aoqia194 aoqia194 added this to the v1.4.0 milestone Oct 14, 2026
@Stikulzon

Stikulzon commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Isn't agentlib relative path and agentpath is absolute? I don't want absolute paths, as the user should be able to reference it relative to the game jar.

Both support relative path, JVM doesn't validate if path is absolute, the documentation is wrong. But agentlib can be better option if .so or .dylib will be added, because it's automatically appends platform-specific library suffix (and the reason why current one doesn't work, it's looking for -agentlib:.leaf/lib/native-%s.dll.dll)

@aoqia194

Copy link
Copy Markdown
Member

Do you think it would be preferable to have the option that excludes the suffix for brevity?

@Stikulzon

Copy link
Copy Markdown
Contributor Author

Yes I guess, ZombieBuddy does this

@aoqia194 aoqia194 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contributions! Also because I forgot to mention, excluding the prefix means that the argument can be the same on all platforms.

@aoqia194
aoqia194 merged commit 62f27cb into LeafPZ:main Oct 14, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from review to done in Global Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/medium Can wait a while without impacting other things risk/low Contains almost no risk of breaking type/fix

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

2 participants