Modify TM4B.config attributes instead of setting attributes for Client#9
Open
digitalfrost wants to merge 1 commit intoLeadformance:masterfrom
Open
Modify TM4B.config attributes instead of setting attributes for Client#9digitalfrost wants to merge 1 commit intoLeadformance:masterfrom
digitalfrost wants to merge 1 commit intoLeadformance:masterfrom
Conversation
Client initializer method now modifies TM4B.config attributes instead of setting :username, :client and :use_ssl attributes for Client instances. This allows to remove references to these attributes in the Client request method which in turn will facilitate further refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client initializer method now modifies TM4B.config attributes instead of
setting :username, :client and :use_ssl attributes for Client instances.
This allows to remove references to these attributes in the Client request
method which in turn will facilitate further refactoring.