Skip to content

fix: let generate_entity_instances preserve login information #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeMyst merged 2 commits into from
Oct 24, 2025
Merged

fix: let generate_entity_instances preserve login information #912

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bf586a
fix: let generate_entity_instances preserve login information
lihaohong6 Sep 27, 2025
fd1f290
Instantiate WikibaseIntegrator with is_bot argument
LeMyst Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions wikibaseintegrator/wbi_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,9 +739,9 @@ def generate_entity_instances(entities: str | list[str], allow_anonymous: bool =
reply = mediawiki_api_call_helper(data=params, allow_anonymous=allow_anonymous, **kwargs)

entity_instances = []
from wikibaseintegrator import WikibaseIntegrator
for qid, v in reply['entities'].items():
from wikibaseintegrator import WikibaseIntegrator
wbi = WikibaseIntegrator()
wbi = WikibaseIntegrator(is_bot=kwargs.get('is_bot', False), login=kwargs.get('login', None))
f = [x for x in BaseEntity.__subclasses__() if x.ETYPE == v['type']][0]
ii = f(api=wbi).from_json(v)
entity_instances.append((qid, ii))
Expand Down Expand Up @@ -1034,3 +1034,4 @@ def download_entity_ttl(entity: str, wikibase_url: str | None = None, user_agent
# # It's really the good way to solve this?
# from wikibaseintegrator import wikibaseintegrator
# return wikibaseintegrator.wbi_helpers

Loading