refactor: route GameListItem and install overlay colors through the theme - #73
Merged
Merged
Conversation
…heme Lot 2/4 of the hardcoded-color migration (docs/sonnet5-specs/02 §6), built on refactor/theme-hardcoded-colors-lot1. GameListItem.kt: card container/border, icon placeholder background/ border, game name, size/download-label text, unfavorited star tint, expanded divider, description surface/text now read MaterialTheme.colorScheme instead of Color(0xFF121212)/Color(0xFF1E1E1E)/ Color.Black/Color.White/Color.Gray/Color.LightGray. MainActivity.kt install-related overlays (SyncingOverlay, LoadingScreen, ErrorScreen, InstallationOverlay, BottomQueueBar): same treatment for backgrounds, borders and neutral text/icon colors. ErrorScreen's 'Try Again' button text was hardcoded Color.White on a colorScheme.secondary background - same latent contrast bug as lot 1's filter chips, fixed with onSecondary. Deliberately NOT touched (semantic status/danger colors, per doc): favorite-star gold, downloaded/ready/installed green-blue-red version badges, permission-warning red, delete/uninstall red, paused-state gray on progress indicators, and the sync-failure card's fixed dark red (kept exact to avoid a default-look diff, since it doesn't match colorScheme.error's dark-theme value). Defaults unchanged for the same reason as lot 1: colorScheme resolves to the original hardcoded hex values (or an indistinguishably close one - 0x1A1A1A vs 0x1E1E1E) with default AppearanceSettings.
PR Validation Summary ✅Status: All checks passed!
Reports and artifacts (including Lint HTML) are available in the Artifacts Tab of the Action Run Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces hardcoded colors in GameListItem, SyncingOverlay, LoadingScreen, ErrorScreen, InstallationOverlay and BottomQueueBar with MaterialTheme.colorScheme equivalents. Builds on #64, #70, #71, #72.