chore: remove dead code and guard empty icon filename in MainRepository - #63
Merged
Merged
Conversation
- Remove val config: ServerConfig? (always null, never reassigned, never read). - Remove resolveUserTier() (unused; only resolveUserTierOrDefault() is called anywhere). - Remove fetchConfig() (@deprecated, always returns null, no callers). - Drop the now-unused PublicConfig import. - Guard the icon extraction branch in extractMetaToCache() with fileName.isNotEmpty(), matching the thumbnails/notes/trailers branches, so a 7z entry ending in "/" can't produce a File with an empty name.
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 679bc85. |
PR Validation Summary ✅Status: All checks passed!
Reports and artifacts (including Lint HTML) are available in the Artifacts Tab of the Action Run Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objectif
Nettoyage groupé (A4 + A5 du backlog) : suppression de code mort confirmé, et un garde de robustesse mineur dans le même fichier.
Changements
val config: ServerConfig? = null— jamais réassigné, jamais lu ailleurs (confirmé par grep).resolveUserTier()— aucun appelant (seulresolveUserTierOrDefault()est utilisé).fetchConfig()—@Deprecated, retourne toujoursnull, aucun appelant.PublicConfigdevenu inutilisé.extractMetaToCache(): la branche d'extraction des icônes (.png/.jpg) ne testait pasfileName.isNotEmpty()avantFile(iconsDir, fileName), contrairement aux branchesthumbnails/notes/trailers. Ajout du même garde.Vérification
scripts\gradlew.bat :app:assembleDevDebug→ succès.scripts\gradlew.bat :app:testDevDebugUnitTest→ succès (aucune régression).Pixel_7,com.vrhub.debug) : lancement à froid sans crash, logcat propre.Réf :
docs/sonnet5-specs/01-bug-audit-backlog.md#a4--code-mort--propriété-trompeuseet#a5--extraction-meta--garde-de-nom-de-fichier-icône-incomplète