Skip to content

feat: close WOR-108 legacy orchestration gate - #34

Merged
Ldsystem merged 36 commits into
mainfrom
feat/wor-108-legacy-closure
Sep 6, 2026
Merged

Ldsystem merged 36 commits into
mainfrom
feat/wor-108-legacy-closure

Conversation

@Ldsystem

@Ldsystem Ldsystem commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • add native scoped task and WOR-98 stage repair reviews while preserving original execution bindings and reusable evidence
  • require subagent ownership for implementation and repair tasks, fail closed without subagents, retain planner-proven fan-out, and retire current prefer_subagent/visibility semantics
  • bound task and review context through lossless seat-specific projection with compact evidence identities and context telemetry
  • close the RF, SG, CTX, and DF fixture registry and publish the migration-impact manifest for the later baseline-advancement gate

Accepted identity

  • Commit: 59699f825637733bdd6e8996c7619e0fead88d4f
  • Tree: 0a6639bc70a4be591b7ff84b6f43d765a79c17c3
  • Integrated review: review-wor108-integrated-20260906-004 (accepted, no findings)

Validation

  • WOR-108 verifier: 22 fixtures, 40 migration surfaces, accepted
  • Focused integrated suite: 624 passed, 7 skipped
  • Canonical release gate: 41/41 modules plus skills passed
  • Final INT-002 scoped checks: exact RF nodes 6 passed; SG-04 production node 1 passed; closure 6 passed; verifier accepted

Scope

Closes WOR-108. Does not start WOR-109, WOR-107, or WOR-79 and does not modify work-bundle-mcp.

@Ldsystem Ldsystem left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two blocking acceptance-path issues in the WOR-108 implementation. Both are on the production completion path, not just fixture formalism. Details inline. The scoped re-review/context work otherwise looks directionally consistent with WOR-108, but I would not merge until these fail-closed gaps are repaired and covered by regression tests.

Comment thread scripts/orchestration/execution_context.py Outdated
Comment thread scripts/orchestration/execution_context.py Outdated

Ldsystem commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

CI is also currently red on both Ubuntu and macOS. The canonical gate fails in tests/test_wor105_native_transition.py::test_native_transition_binds_accepted_kernel_source_identity because evals/wor105/components/native-transition-record.yaml pins accepted_commit: 10aa3aceeea4c440feaccb484b897af67cd0df0b, but that commit is not reachable/fetchable from the GitHub repository checkout (git rev-parse 10aa3ace...^{tree} exits 128 even with fetch-depth: 0). This contradicts the PR body's canonical-green claim and makes the accepted native-transition identity non-reproducible off the originating local repo. Please make the accepted identity remotely reproducible (e.g. bind to a reachable commit with the same accepted tree, or otherwise carry a verifiable immutable tree identity without requiring an unreachable local commit) and rerun both deterministic jobs.

@Ldsystem Ldsystem left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review at head fdd5940d63634eb3c94165ac3948bf5c397c08c7 (tree 12e4a696c3caf991654f0b9ac9ef40594699c8d4). The two previously blocking completion-path defects are fixed: fresh initial review-reset completion now composes through the real acceptance path, and completed-task ownership evidence now fails closed when mutation attestation is absent; archive forwards the current compatibility input instead of silently defaulting it. Mutation-event path normalization also closes the reviewed ./ / repeated-separator bypass. GitHub CI run 81 is green on both deterministic Ubuntu and macOS jobs.

I found no remaining WOR-108 product defect that should block this merge. The remaining design debt is explicitly carried into WOR-109: post-acceptance lifecycle replay (mutation_events/ownership/repair evidence), recovery/full handoff-chain reconstruction in the common path, separation of historical task acceptance identity from later release/reproducibility anchors, and canonicalization of both observed and declared scope paths. These should be corrected by the accepted-result simplification rather than extending WOR-108 again.

@Ldsystem
Ldsystem merged commit cfa089f into main Sep 6, 2026
2 checks passed
@Ldsystem
Ldsystem deleted the feat/wor-108-legacy-closure branch September 6, 2026 06:25
@Ldsystem

Ldsystem commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

WOR-108 final repair merged from exact head fdd5940, tree 12e4a696c3caf991654f0b9ac9ef40594699c8d4. CI reproducibility uses accepted WOR-105 commit 9dce5df and tree 5a1f38355eae8068bab528923e807ce54e6f6fe5, available in a normal GitHub checkout. WOR-108 verification accepted 22 fixtures and 44 changed surfaces. Final local canonical result: 41 of 41 modules passed and skills passed. GitHub deterministic Ubuntu and macOS jobs both passed. Merge commit: cfa089f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant