Repository navigation
docs: fix quickstart flags and Python version - #1
Open
mosesman831 wants to merge 1 commit into
Open
mosesman831 wants to merge 1 commit into
mosesman831 wants to merge 1 commit into
Conversation
- source register takes --source, not --file. - import commit requires --expected-revision (compare-and-swap; fails REQUEST_INVALID without it). - init requires --trust (genesis-zero head pins only) and --principal naming a configured admin; --request-id was also missing. - Python parity suite passes on 3.10, so relax the stated >=3.11 to >=3.10 (no pyproject pins otherwise). - Note native/peercred is required by serve, that the JSON inputs are operator-maintained (fixture shapes in test/fixture.ts), and that ANCHORED needs trust heads pinning the live chain heads.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three flag fixes and a version correction in the quickstart, all verified against the real CLI:
source registertakes--source, not--file.import commitrequires--expected-revision— it compare-and-swaps against the stored revision and failsREQUEST_INVALIDwithout it (shown as1, sincesource.registerproduces revision 1).initrequires--trust(whoseheadsmay pin only genesis-zero heads) and--principalnaming a configuredadmin, plus--request-id.pyproject.toml) and the parity suite passes 8/8 on 3.10.12.test/fixture.ts), thatnpm run build:nativeis required byserve(thepeercredhelper provides caller identity), and that--require ANCHOREDneeds trustheadspinning the live audit head and source cuts —INTEGRITY/RECONSTRUCTIONdon't.Verified end-to-end on a fresh VM with the fixture materialized from
test/fixture.ts:init→serve→source register --source→import stage→import commit --expected-revision 1→export→verify --require ANCHOREDreturningaccepted:true.npm testpasses (72/72).Link to Devin session: https://app.devin.ai/sessions/5fcebb20f9a0438daaa48abc90b25087
Open in Devin Desktop: https://app.devin.ai/desktop/session/5fcebb20f9a0438daaa48abc90b25087?variant=devin
Requested by: @mosesman831