Skip to content

chore: remove the remaining unflagged run-internal labels (task 5fc59ff7) - #260

Merged
LanNguyenSi merged 3 commits into
masterfrom
chore/5fc59ff7-unflagged-run-labels
Sep 29, 2026
Merged

LanNguyenSi merged 3 commits into
masterfrom
chore/5fc59ff7-unflagged-run-labels

Conversation

@LanNguyenSi

Copy link
Copy Markdown
Owner

Removes run-internal labels that slop-detector's review-slop pack does not flag, so no public comment, test title or OKF doc points at a label an outside reader cannot resolve.

  • packages/grounding-mcp/src/ow-run-completeness.ts: "(Fix 1)" / "(Fix 2)" dropped from the docblock (comments only; tsc --removeComments output identical at base and head for the whole package).
  • packages/grounding-mcp/tests/ow-run-completeness.test.ts: five describe/test titles reworded (Fix 1 to Fix 4, P7); titles only.
  • docs/okf/solution-acceptance-verdict-contract.md: decision ids D-001, D-002, D-003 replaced by the behaviour they stood for; the quotation-exemption heading now says it was added in grounding-mcp 0.10.0 together with the phrase net it narrows and points at that CHANGELOG entry. Each rewording sourced from git history (bd9b69d, d0f201f) and the CHANGELOG. Line counts unchanged, so no cited range moved; all anchored citations re-verified; doc re-stamped, one top docs/okf/log.md entry.

Verification:

  • rg -n "\(Fix [0-9]\)|P7:" packages and rg -n "\bD-0[0-9]{2}\b" docs/okf --glob '!log.md': 7 and 4 hits at base, none at head.
  • build, typecheck, test (grounding-mcp 602 tests), check:okf-test-citation-shape, check:okf-selectors, check:shipped-unreleased-pointer: exit 0.
  • npx -y okf-kit@0.10.0 check --require-anchors docs/okf: identical at base and head (0 errors, 8 pre-existing warnings in log.md history).

Closes task 5fc59ff7.

🤖 Generated with Claude Code

Lan Nguyen Si and others added 3 commits September 29, 2026 08:47
…ness comments and test titles (task 5fc59ff7)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…oc and re-stamp (task 5fc59ff7)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ier release (task 5fc59ff7)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LanNguyenSi LanNguyenSi added review:tests-pass merge-approval prereq review:checklist-complete merge-approval prereq review:comments-resolved merge-approval prereq review:scope-matches-task merge-approval prereq review:evidence-logged merge-approval prereq labels Sep 29, 2026
@LanNguyenSi
LanNguyenSi merged commit 0a6469b into master Sep 29, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:checklist-complete merge-approval prereq review:comments-resolved merge-approval prereq review:evidence-logged merge-approval prereq review:scope-matches-task merge-approval prereq review:tests-pass merge-approval prereq

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant