Repository navigation
skill: skip_reason prefixes come only from rook's own validation - #55
Merged
gauravBansal06 merged 1 commit intoOct 14, 2026
Merged
Conversation
A signed-in 0.1.11 run of samples/triage-service showed checker-written
skip reasons as plain sentences ("The scenario requires ticket T-1043 to
exist..."), so the skill should read `executable`, not match a prefix.
The same run's plain generate planned no attacks; say how to ask for them.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gauravBansal06
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A signed-in run of the published
rook 0.1.11againstsamples/triage-serviceturned up two things the skill (released today as@testmuai/rook-skill@0.1.11, via #52) states too strongly:skip_reasonstarts withcoverage gap:,invalid scenario:orinvalid red-team scenario:only when rook's own validation wrote it. In the run, the checker's reasons were plain sentences, for example "The scenario requires ticket T-1043 to exist…". The skill now says to readexecutableinstead of matching a prefix.generate: a plaingenerateplanned 9 functional scenarios and no attacks. The skill now says to runrook generate --class adversarial --json, and to say so, when the user asked for red-team coverage and none was written.Only
references/scenarios.mdchanges, regenerated into both mirrors withscripts/sync-skill-mirrors.sh. No release is needed now; this ships with the next skill publish.Checks (against rook 0.1.11)
test-skill-mirrors: pass.test-skill-flags: 47 command lines pass.test-skill-contract: 16/16.🤖 Generated with Claude Code