Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 39 additions & 34 deletions content.js
Original file line number Diff line number Diff line change
Expand Up @@ -1607,15 +1607,16 @@ class YTMBlockController {
const anchors = responsiveItem.querySelectorAll('a');
for (const a of anchors) {
const href = a.getAttribute('href') || '';
const text = a.textContent.trim();
if ((href.includes('/browse/UC') || href.includes('/channel/UC') || href.includes('/artist/') ||
(href.includes('/browse/') && !href.includes('/browse/VL') && !href.includes('/browse/MPRE') && !href.includes('/watch?v='))) &&
text) {
return {
value: text,
confidence: 0.9,
source: 'Row Artist Link extraction'
};
if (href.includes('/browse/UC') || href.includes('/channel/UC') || href.includes('/artist/') ||
(href.includes('/browse/') && !href.includes('/browse/VL') && !href.includes('/browse/MPRE') && !href.includes('/watch?v='))) {
const text = a.textContent.trim();
if (text) {
return {
value: text,
confidence: 0.9,
source: 'Row Artist Link extraction'
};
}
}
}
const subtitleEl = responsiveItem.querySelector('.subtitle') || responsiveItem.querySelector('.secondary-flex-columns') || responsiveItem.querySelector('.flex-column:nth-child(2)');
Expand All @@ -1638,15 +1639,16 @@ class YTMBlockController {
const anchors = queueItem.querySelectorAll('a');
for (const a of anchors) {
const href = a.getAttribute('href') || '';
const text = a.textContent.trim();
if ((href.includes('/browse/UC') || href.includes('/channel/UC') ||
(href.includes('/browse/') && !href.includes('/browse/VL') && !href.includes('/browse/MPRE') && !href.includes('/watch?v='))) &&
text) {
return {
value: text,
confidence: 0.9,
source: 'Queue Row Artist Link extraction'
};
if (href.includes('/browse/UC') || href.includes('/channel/UC') ||
(href.includes('/browse/') && !href.includes('/browse/VL') && !href.includes('/browse/MPRE') && !href.includes('/watch?v='))) {
const text = a.textContent.trim();
if (text) {
return {
value: text,
confidence: 0.9,
source: 'Queue Row Artist Link extraction'
};
}
}
}
const bylineEl = queueItem.querySelector('.byline') || queueItem.querySelector('[class*="byline"]') || queueItem.querySelector('.secondary-title');
Expand Down Expand Up @@ -1747,15 +1749,16 @@ class YTMBlockController {
const anchors = container.querySelectorAll('a');
for (const a of anchors) {
const href = a.getAttribute('href') || '';
const text = a.textContent.trim();
if ((href.includes('/browse/UC') || href.includes('/channel/UC') ||
(href.includes('/browse/') && !href.includes('/browse/VL') && !href.includes('/browse/MPRE') && !href.includes('/watch?v='))) &&
text) {
return {
value: text,
confidence: 0.7,
source: 'Generic Container Artist Link extraction'
};
if (href.includes('/browse/UC') || href.includes('/channel/UC') ||
(href.includes('/browse/') && !href.includes('/browse/VL') && !href.includes('/browse/MPRE') && !href.includes('/watch?v='))) {
const text = a.textContent.trim();
if (text) {
return {
value: text,
confidence: 0.7,
source: 'Generic Container Artist Link extraction'
};
}
}
}
}
Expand Down Expand Up @@ -1924,13 +1927,15 @@ class YTMBlockController {
const anchors = responsiveItem.querySelectorAll('a');
for (const a of anchors) {
const href = a.getAttribute('href') || '';
const text = a.textContent.trim();
if ((href.includes('/browse/MPRE') || href.includes('/browse/FIBY')) && text) {
return {
value: text,
confidence: 0.9,
source: 'Row Album Link extraction'
};
if (href.includes('/browse/MPRE') || href.includes('/browse/FIBY')) {
const text = a.textContent.trim();
if (text) {
return {
value: text,
confidence: 0.9,
source: 'Row Album Link extraction'
};
}
}
}
const subtitleEl = responsiveItem.querySelector('.subtitle') || responsiveItem.querySelector('.secondary-flex-columns');
Expand Down
59 changes: 59 additions & 0 deletions tests/textContentBenchmark.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
const test = require('node:test');
const assert = require('node:assert');
const { performance } = require('node:perf_hooks');
const { YTMBlockController } = require('../content.js');

test('extractArtist - benchmark textContent evaluation overhead', () => {
const controller = new YTMBlockController();

const anchorsData = [
{ href: '/watch?v=12345', text: 'Song Title' },
{ href: '/browse/VL12345', text: 'Playlist Title' },
{ href: '/browse/MPRE12345', text: 'Album Title' },
{ href: '/watch?v=67890', text: 'Video Title' },
{ href: '/artist/UC123456789', text: ' Artist Name ' }
];

let textAccesses = 0;

function createMockTarget() {
const mockAnchors = anchorsData.map(({ href, text }) => ({
getAttribute(attr) { return attr === 'href' ? href : null; },
get textContent() {
textAccesses++;
return text;
}
}));

const mockResponsiveItem = {
querySelectorAll(selector) { return selector === 'a' ? mockAnchors : []; },
querySelector() { return null; }
};

return {
closest(selector) {
return selector === 'ytmusic-responsive-list-item-renderer' ? mockResponsiveItem : null;
}
};
}

const target = createMockTarget();
const iterations = 500000;

// Warmup V8
for (let i = 0; i < 10000; i++) controller.extractArtist(target);

textAccesses = 0;
const start = performance.now();
for (let i = 0; i < iterations; i++) {
controller.extractArtist(target);
}
const duration = performance.now() - start;

console.log(`[Benchmark] extractArtist optimized implementation: ${duration.toFixed(2)}ms (${textAccesses} textContent accesses across ${iterations} iterations)`);

const result = controller.extractArtist(target);
assert.strictEqual(result.value, 'Artist Name');
assert.strictEqual(result.source, 'Row Artist Link extraction');
assert.strictEqual(textAccesses / (iterations + 1), 1, 'textContent should only be accessed once per loop iteration for matching href');
});
Loading