Repository navigation
🧹 Refactor normalizeArtist to delegate to normalizeEntry - #18
github-actions[bot] merged 1 commit into
Conversation
Refactors YTMBlockController.normalizeArtist in content.js to reuse normalizeEntry from storage.js for string cleaning and lowercasing. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What:
Refactored
normalizeArtistincontent.jsto delegate initial string cleaning (lowercasing, whitespace trimming and collapsing, zero-width character removal) tonormalizeEntryfromstorage.js.💡 Why:
Eliminates duplicate normalization logic across files and ensures consistent string sanitization rules across the extension while preserving the specific non-word character stripping for artist names.
✅ Verification:
Executed
npm testand verified all unit tests (includingnormalizeArtist.test.js) pass. Ran./build.shto confirm extension packaging succeeds.✨ Result:
Cleaner code maintainability and eliminated logic duplication.
PR created automatically by Jules for task 3703692011367422370 started by @Labreo