Skip to content

Scroll the domain designer save button into view #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-tchad wants to merge 3 commits into
base: develop
Choose a base branch
from
+9 −1
Open

Scroll the domain designer save button into view #2847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3346a32
Scroll the domain designer save button into view
labkey-tchad Jan 16, 2026
2eec335
add comments
labkey-tchad Jan 16, 2026
b843b77
Merge remote-tracking branch 'origin/develop' into fb_fixDomainScroll
labkey-tchad Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/org/labkey/test/components/domain/BaseDomainDesigner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import org.labkey.test.Locator;
import org.labkey.test.components.Component;
import org.labkey.test.components.WebDriverComponent;
import org.labkey.test.util.selenium.ScrollUtils;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement;

Expand Down Expand Up @@ -66,7 +67,8 @@ public boolean isSaveButtonEnabled()
*/
public Object clickSave()
{
getWrapper().clickAndWait(elementCache().saveButton);
// Selenium sometimes doesn't think the save button needs to be scrolled into view but the click does nothing.
getWrapper().clickAndWait(ScrollUtils.scrollIntoView(elementCache().saveButton));
return null;
}

Expand Down
6 changes: 6 additions & 0 deletions src/org/labkey/test/components/ui/domainproperties/EntityTypeDesigner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@ public T setNameExpression(String nameExpression)
{
expandPropertiesPanel();
elementCache().nameExpressionInput.set(nameExpression);
if (nameExpression.contains("${genId}"))
{
// Wait for genId banner to avoid interfering with subsequent steps by shifting the page layout
// Non-fatal to let specific tests check for this
var _ = WebDriverWrapper.waitFor(this::isGenIdVisible, 1_000);
}
return getThis();
}

Expand Down