Return starting model and config file for delay calibration#101
Return starting model and config file for delay calibration#101
Conversation
lonbar
left a comment
There was a problem hiding this comment.
Looks good to me. A few minor syntax nits.
|
I'm wondering if it makes sense to bundle outputs such as these into a |
I'm not sure I fully understand. Do you mean in the sense of the contents of these files in a JSON file? |
|
@tikk3r perhaps, yes. I am mostly thinking out loud here. We could collect and store all the individual files, but perhaps it's useful to create a data structure that contains all the parameters and their values per parset, perhaps with some information/metadata such as which steps they are used in. |
It sounds like an interesting idea. The nice thing about having the files is that they are in the format expected by the software, so we don't have to reconstruct it. Maybe something for another time? |
Co-authored-by: Matthijs van der Wild <lonbar@users.noreply.github.com>
44643d6 to
382fe9f
Compare
That's fine. My main concern was that it may not be obvious which file to apply where, but we can leave it as it is for now. |
I recently found myself in multiple scenarios where I needed to re-run or tweak the delay calibration on difficult fields. With settings and skymodels now being generated automatically, this is cumbersome at the moment as they are not outputs of the main workflow and as such do not "survive" a successful pipeline run. This PR adds the starting models as outputs of the pipeline as well as the config file that comes from phaseup-concat (the automatic selection does not yet generate config files, I'll leave that for a future PR). This should improve reproducibility in general as well by having easier access to the combination of model and settings that were used.