Skip to content

docs: fix quick start Maven coordinates - #52

Open
thehanslevi wants to merge 1 commit into
LMLiam:mainfrom
thehanslevi:codex/fix-spi-tooling-coordinates
Open

docs: fix quick start Maven coordinates#52
thehanslevi wants to merge 1 commit into
LMLiam:mainfrom
thehanslevi:codex/fix-spi-tooling-coordinates

Conversation

@thehanslevi

@thehanslevi thehanslevi commented Jun 20, 2026

Copy link
Copy Markdown

Summary

  • Updates the README Quick Start dependency snippets to use io.github.eventhorizonlab.
  • Uses spi-tooling-processor for the Groovy annotationProcessor example, matching the published processor artifact.

Related Issue

Validation

  • Checked gradle.properties: group=io.github.eventhorizonlab.
  • Checked build.gradle: Maven publishing coordinates use rootProject.group and ${rootProject.name}-${project.name}.
  • Checked settings.gradle: published subprojects are annotations and processor.
  • Checked Maven Central metadata plus 0.1.23 POM/JAR URLs for:
    • io.github.eventhorizonlab:spi-tooling-annotations
    • io.github.eventhorizonlab:spi-tooling-processor
  • Confirmed stale Maven Central paths return 404 for com.github.eventhorizonlab:* and io.github.eventhorizonlab:spi-tooling.
  • Ran git diff --check.

I also tried a minimal Gradle dependency-resolution project with the corrected coordinates, but this local host has no Java runtime installed, so Gradle could not start.

Summary by CodeRabbit

  • Documentation
    • Updated README Gradle build configuration examples to reference current Maven repository coordinates.
    • Corrected annotation processor dependency identifier and synchronized both Groovy DSL and Kotlin DSL code examples with accurate dependency names.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The README's "Add the dependency" Gradle snippets are corrected: the Maven group is changed from com.github.eventhorizonlab to io.github.eventhorizonlab across all occurrences, and the Groovy DSL Java annotationProcessor artifact is fixed from spi-tooling to spi-tooling-processor.

Changes

README Maven Coordinates Fix

Layer / File(s) Summary
Gradle dependency snippet corrections
README.md
Both Groovy and Kotlin DSL Quick Start snippets updated to use io.github.eventhorizonlab as the Maven group, and the Groovy DSL Java annotationProcessor artifact corrected from spi-tooling to spi-tooling-processor.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • #22 (docs(readme): fix incorrect Maven coordinates in the Quick Start): This PR directly implements the fix described in the issue — replacing com.github.eventhorizonlab with io.github.eventhorizonlab and correcting the spi-tooling annotationProcessor artifact to spi-tooling-processor in both DSL blocks.
  • #33: The retrieved issue covers broader documentation typos and broken links in README.md; the Maven coordinates fix in this PR is one of the documentation improvements referenced in that issue's scope.

Poem

🐇 Hoppity-hop, the coords were wrong,
A typo crept into the README song.
com.github has gone, replaced with io,
And spi-tooling-processor steals the show!
Now copy-paste works — off we go! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs: fix quick start Maven coordinates' accurately summarizes the main change of correcting Maven group ID and artifact names in README Quick Start snippets.
Description check ✅ Passed The PR description comprehensively covers the Summary, Related Issue, and Validation sections with detailed verification steps, though some template sections like Modules Affected and Checklist items are not formally addressed.
Linked Issues check ✅ Passed The PR fully addresses issue #22 requirements: Maven coordinates updated from com.github.eventhorizonlab to io.github.eventhorizonlab, annotation processor artifact corrected to spi-tooling-processor, and consistency verified across README.
Out of Scope Changes check ✅ Passed All changes are within scope—only README Quick Start Maven coordinates and annotation processor artifact names were modified, aligning with issue #22 requirements with no extraneous alterations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Around line 45-47: The markdown file does not comply with MD031 by missing
blank lines around the code fence. Add a blank line before the "Gradle kts:"
text and another blank line between "Gradle kts:" and the opening code fence
(```kotlin) to ensure proper spacing between text and fenced code blocks as
required by markdown linting standards.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: fbf6f97f-0ce5-40c3-9112-b27be0b2cae4

📥 Commits

Reviewing files that changed from the base of the PR and between fdc0ff3 and b6430ae.

📒 Files selected for processing (1)
  • README.md

Comment thread README.md
Comment on lines 45 to 47
```
Gradle kts:
```kotlin

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Add blank lines around code fences to comply with MD031.

Markdown best practice requires blank lines between text and fenced code blocks for readability and linting compliance.

📝 Proposed fix to add blank lines
     annotationProcessor("io.github.eventhorizonlab:spi-tooling-processor:<version>")
 }

Gradle kts:
+

dependencies {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
```
Gradle kts:
```kotlin
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)

[warning] 45-45: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 47-47: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 45 - 47, The markdown file does not comply with MD031
by missing blank lines around the code fence. Add a blank line before the
"Gradle kts:" text and another blank line between "Gradle kts:" and the opening
code fence (```kotlin) to ensure proper spacing between text and fenced code
blocks as required by markdown linting standards.

Source: Linters/SAST tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(readme): fix incorrect Maven coordinates in the Quick Start

1 participant