docs(fix): fix typos and broken license badge link in README and CONTRIBUTING - #49
docs(fix): fix typos and broken license badge link in README and CONTRIBUTING#49MaxwellM34 wants to merge 3 commits into
Conversation
Signed-off-by: Maxwellm34 <maxwellmcinnis123@gmail.com>
📝 WalkthroughWalkthroughThis PR makes four minimal corrections: README license badge now links to ChangesDocumentation Corrections
Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Line 111: Replace the duplicated phrase in the line that currently reads
"Think about future maintainers - clear code, clear code, clear tests" so it
becomes either "Think about future maintainers - clear code, clear docs, clear
tests" or "Think about future maintainers - clear code, clear tests" (choose one
consistent wording), and ensure the file ends with exactly one newline
character; update the CONTRIBUTING.md sentence and add a single trailing newline
at EOF.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1241ff68-f80c-4bdd-a8e0-77b9be7e7dcf
📒 Files selected for processing (2)
CONTRIBUTING.mdREADME.md
…docs' + add trailing newline The prior commit on this PR replaced 'clear cods' with 'clear code', creating a duplicate of the preceding 'clear code' phrase. The original typo 'cods' was clearly meant to be 'docs' — fixing to that. Also adds the missing trailing newline that markdownlint-cli2 (and CodeRabbit's MD047 check) flagged. Two-line change, no other diffs. Addresses @coderabbitai review on PR LMLiam#49. Signed-off-by: Maxwellm34 <maxwellmcinnis123@gmail.com>
|
Thanks @coderabbitai. The original line in main was |
|
Tip For best results, initiate chat on the files or code changes.
(ミ^ᴗ^ミ) ✏️ Learnings added
|
|
Hi @MaxwellM34, thank you for your contribution. From this PR run, you will need to bump the version in gradle.properties to 0.1.22 if possible - thank you :) |
Per @LMLiam's request on PR LMLiam#49 (https://github.com/LMLiam/SPI-Tooling/actions/runs/27125535368/job/80167831152?pr=49) the repo expects the version to be bumped in the same PR. Patch bump since this is a documentation-only fix. Signed-off-by: Maxwellm34 <maxwellmcinnis123@gmail.com>
|
Done — bumped |
|
@LMLiam heads-up — the failing The signing-key secret used by the snapshot publish workflow appears to be malformed (or empty). My PR doesn't touch the build or the workflow — it's a docs-only fix plus the version bump you asked for. Whenever the secret is sorted out, a re-run of the workflow should succeed without any code change here. Happy to retry if you want me to push an empty commit to nudge it after. |
Fixes several documentation defects identified in #33: corrects invalid Kotlin syntax
Contract:class→Contract::classin README features list, fixes the license badge link to point toLICENSE.md, and corrects the 'clear cods' typo in CONTRIBUTING.md. The.githubtemplate placeholder is excluded as it falls outside pure documentation scope.This contribution was AI-assisted (Claude). It's a small targeted fix — happy to revise, or just close if it's not a direction you want. No offense taken.
Summary by CodeRabbit